Add python implementation of LBPs #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johngrantuk
reviewed
Jun 23, 2025
|
|
||
|
|
||
| class PoolBase(ABC): | ||
| @abstractmethod |
There was a problem hiding this comment.
Can you explain why this is added in this PR?
There was a problem hiding this comment.
Sure! This fixes a lint issue I had missed when instantiating pool_class on _get_pool from vault. Adding the custom __init__ on the abstract class (i.e. interface) makes it clear that pool_base implementations require pool_state to be passed as input.
johngrantuk
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #128