Skip to content

Add ReClammV2 support in python #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 28, 2025
Merged

Add ReClammV2 support in python #132

merged 4 commits into from
Jul 28, 2025

Conversation

brunoguerios
Copy link
Member

@brunoguerios brunoguerios commented Jul 25, 2025 •
edited
Loading

Closes #130

Also:

  • fix some imports
  • remove unnecessary path manipulation on test files (make sure to use pytest for testing instead of running test files directly)
  • fix remaining int division to use custom BigInt behavior

@brunoguerios brunoguerios requested a review from johngrantuk July 25, 2025 18:28
@brunoguerios brunoguerios self-assigned this Jul 25, 2025
johngrantuk
johngrantuk approved these changes Jul 28, 2025
View reviewed changes
Copy link
Member

@johngrantuk johngrantuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@brunoguerios brunoguerios merged commit 3efa13e into main Jul 28, 2025
2 checks passed
@brunoguerios brunoguerios deleted the reclamm-v2-python branch July 28, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngrantuk johngrantuk johngrantuk approved these changes

Assignees

@brunoguerios brunoguerios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ReClammV2 maths in python
2 participants
@brunoguerios @johngrantuk