Skip to content

fixed assert if task and mesh shader entrypoint names differ #3317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2024

Conversation

Firestar99
Copy link

@Firestar99 Firestar99 commented May 16, 2024

Description

If the entrypoint name of the task and mesh shaders differ, this assert is triggered:

RDCASSERT(entryID);

This PR fixes a typo where the entrypoint of the mesh shader is being passed over instead of the task:

AddTaskShaderPayloadStores(taskShad.specialization, meshShad.entryPoint, bufSpecConstant + 1,

You can rename the spirv entry point with: glslangValidator -V bla.task -e notMainEntryPoint --source-entrypoint main --target-env vulkan1.2
Small repo capture: varying_entrypoint_names_crash.zip

@baldurk baldurk merged commit db553fc into baldurk:v1.x May 16, 2024
16 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants