Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninstall containers using force remove #2330

Closed
wants to merge 1 commit into from
Closed

Conversation

pipex
Copy link
Contributor

@pipex pipex commented May 8, 2024

When uninstalling a container for a restart from the API on when moving between releases, this prefers to force remove the container rather than stop then remove. This has the same effect in the end, but force remove is an atomic call, meaning if the supervisor is killed between the stop and remove, the engine will proceed with the operation and the supervisor will know to recover from the target state after the restart.

Change-type: patch
Relates-to: #2257

When uninstalling a container for a restart from the API on when
moving between releases, this prefers to force remove the container
rather than stop then remove. This has the same effect in the end, but
force remove is an atomic call, meaning if the supervisor is killed
between the stop and remove, the engine will proceed with the operation
and the supervisor will know to recover from the target state after the
restart.

Change-type: patch
Relates-to: #2257
@flowzone-app flowzone-app bot enabled auto-merge May 8, 2024 01:52
@pipex
Copy link
Contributor Author

pipex commented May 9, 2024

This is not the right solution, force remove uses SIGKILL instead of sigterm

docker rm --help                                                                                                           dynamic-sensors

Usage:  docker rm [OPTIONS] CONTAINER [CONTAINER...]

Remove one or more containers

Aliases:
  docker container rm, docker container remove, docker rm

Options:
  -f, --force     Force the removal of a running container (uses SIGKILL)
  -l, --link      Remove the specified link
  -v, --volumes   Remove anonymous volumes associated with the container

@pipex pipex closed this May 9, 2024
auto-merge was automatically disabled May 9, 2024 21:08

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant