Make hostapp-deploy depend on a successful s3-deploy #649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klutchell
temporarily deployed
to
balena-staging.com
GitHub Actions
Inactive
klutchell
temporarily deployed
to
balena-staging.com
GitHub Actions
Inactive
klutchell
temporarily deployed
to
balena-cloud.com
GitHub Actions
Inactive
klutchell
temporarily deployed
to
balena-cloud.com
GitHub Actions
Inactive
klutchell
temporarily deployed
to
balena-cloud.com
GitHub Actions
Inactive
rcooke-warwick
approved these changes
May 28, 2025
If something failed on S3 upload, we do not want to deploy the hostapp as it will likely need to be invalidated. This order will change when we move to web resources, and uploads depend on the hostapp creation. Change-type: minor Signed-off-by: Kyle Harding <[email protected]>
klutchell
force-pushed
the
kyle/hostapp-needs
branch
from
599b2c9 to
7e5c501
Compare
klutchell
temporarily deployed
to
balena-staging.com
GitHub Actions
Inactive
klutchell
temporarily deployed
to
balena-staging.com
GitHub Actions
Inactive
klutchell
temporarily deployed
to
balena-cloud.com
GitHub Actions
Inactive
klutchell
had a problem deploying
to
balena-cloud.com
GitHub Actions
Failure
klutchell
temporarily deployed
to
balena-cloud.com
GitHub Actions
Inactive
klutchell
had a problem deploying
to
balena-cloud.com
GitHub Actions
Failure
klutchell
temporarily deployed
to
balena-cloud.com
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If something failed on S3 upload, we do not want to deploy the hostapp as it will likely need to be invalidated.
This order will change when we move to web resources, and uploads depend on the hostapp creation.
Change-type: minor