-
Notifications
You must be signed in to change notification settings - Fork 768
Copy constant field annotations from inclusions #44178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
heshanpadmasiri
wants to merge
7
commits into
ballerina-platform:master
Choose a base branch
from
heshanpadmasiri:fix/annotion-incl
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Copy constant field annotations from inclusions #44178
heshanpadmasiri
wants to merge
7
commits into
ballerina-platform:master
from
heshanpadmasiri:fix/annotion-incl
+201
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gimantha
reviewed
Jun 23, 2025
...erina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/SymbolEnter.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a stop-gap mechanism to copy constant field annotations when including record fields, along with tests to verify correct behavior.
- Extend the compiler’s
SymbolEnter
to track included record nodes and clone constant annotations onto inlined fields. - Introduce
copyMatchingConstAnnotations
helper and supporting methods to recursively propagate annotations. - Add Ballerina and Java tests to validate that annotations on included fields are correctly copied.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
tests/jballerina-unit-test/src/test/resources/.../annotation.bal | New Ballerina test cases defining record types and invoking checks |
tests/jballerina-unit-test/src/test/java/.../AnnotationTests.java | Added testAnnotationInclusion test method |
tests/jballerina-unit-test/src/test/java/.../ValidateFieldAnnotations.java | New Java helper to assert that field annotations were copied |
compiler/ballerina-lang/.../SymbolEnter.java | Track structure nodes, clone and attach constant annotations |
...unit-test/src/test/java/org/ballerinalang/nativeimpl/jvm/tests/ValidateFieldAnnotations.java
Outdated
Show resolved
Hide resolved
...unit-test/src/test/java/org/ballerinalang/nativeimpl/jvm/tests/ValidateFieldAnnotations.java
Outdated
Show resolved
Hide resolved
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Stop-gap solution for #38535 that only copies constant annotations
Approach
Samples
Remarks
Check List