Add the natural langlib and update the natural expression #44206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ina-lang into add-natural-langlib
Add the natural langlib and update the natural expression
MaryamZi
requested review from
gimantha,
azinneera,
KavinduZoysa,
warunalakshitha,
sameerajayasoma,
hasithaa and
keizer619
as code owners
There was a problem hiding this comment.
Pull Request Overview
Adds the new natural type snippet to a variety of language-server completion test configurations and updates a specific expression context.
- Inserts
"natural"snippet entries into multiple function-body and expression-context JSON configs. - Replaces the existing
"code"annotation snippet in the typeof-expression context with thenaturalsnippet. - Adds blank
"description"fields in some test JSON files.
Reviewed Changes
Copilot reviewed 300 out of 710 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| completion/function_body/config/config18.json | Added "natural" snippet entry for type completions. |
| completion/expression_context/config/typeof_expression_ctx_config5.json | Removed "code" annotation snippet and added the "natural" snippet. |
| completion/expression_context/config/new_expr_ctx_config4.json | Added a blank "description" field and "natural" snippet entries. |
Comments suppressed due to low confidence (2)
language-server/modules/langserver-core/src/test/resources/completion/expression_context/config/typeof_expression_ctx_config5.json:475
- The existing 'code' annotation snippet was removed and replaced by the 'natural' type snippet. If the 'code' snippet is still required in tests, restore and append the 'natural' entry instead of overwriting this block.
"label": "natural",
language-server/modules/langserver-core/src/test/resources/completion/expression_context/config/new_expr_ctx_config4.json:7
- [nitpick] The 'description' field is currently empty; either remove it if unused or provide a meaningful description to clarify the test scenario.
"description": "",
...ver/modules/langserver-core/src/test/resources/completion/function_body/config/config18.json
Show resolved
Hide resolved
...na-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/SymbolResolver.java
Outdated
Show resolved
Hide resolved
...na-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/SymbolResolver.java
Outdated
Show resolved
Hide resolved
...rina-lang/src/main/java/io/ballerina/projects/internal/NaturalProgrammingImportAnalyzer.java
Outdated
Show resolved
Hide resolved
chiranSachintha
previously approved these changes
Jul 14, 2025
MaryamZi
force-pushed
the
natural-expr-update
branch
from
35472ad to
9e0e5a4
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$title.
Introduces the lang changes for #44174