Skip to content

Conversation

@ayeshLK
Copy link
Member

@ayeshLK ayeshLK commented Jul 8, 2025

Purpose

$subject

Fixes: ballerina-platform/ballerina-library#8078

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@codecov
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 78.28%. Comparing base (7f915df) to head (dc57e5c).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
...na/stdlib/java.jms/listener/MessageDispatcher.java 40.00% 6 Missing ⚠️
...io/ballerina/stdlib/java.jms/listener/Service.java 88.46% 2 Missing and 1 partial ⚠️

❌ Your project status has failed because the head coverage (78.28%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #143      +/-   ##
============================================
- Coverage     79.05%   78.28%   -0.78%     
- Complexity      142      148       +6     
============================================
  Files            27       27              
  Lines           888      907      +19     
  Branches        141      145       +4     
============================================
+ Hits            702      710       +8     
- Misses          159      170      +11     
  Partials         27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ThisaruGuruge
ThisaruGuruge previously approved these changes Jul 9, 2025
Copy link
Member

@ThisaruGuruge ThisaruGuruge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for a minor comment.

Copy link
Contributor

@niveathika niveathika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we update examples in the docs?

@ayeshLK
Copy link
Member Author

ayeshLK commented Jul 15, 2025

Shouldn't we update examples in the docs?

Currently we don't have any examples related to onError. Will add an example in a separate PR.

Copy link
Member

@ThisaruGuruge ThisaruGuruge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayeshLK ayeshLK merged commit 4d99bab into ballerina-platform:master Jul 15, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Introduce onError method to handle message dispatching errors

4 participants