-
Notifications
You must be signed in to change notification settings - Fork 22
Introduce onError method to handle message dispatching errors
#143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your project status has failed because the head coverage (78.28%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #143 +/- ##
============================================
- Coverage 79.05% 78.28% -0.78%
- Complexity 142 148 +6
============================================
Files 27 27
Lines 888 907 +19
Branches 141 145 +4
============================================
+ Hits 702 710 +8
- Misses 159 170 +11
Partials 27 27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ThisaruGuruge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for a minor comment.
niveathika
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we update examples in the docs?
native/src/main/java/io/ballerina/stdlib/java.jms/listener/Service.java
Outdated
Show resolved
Hide resolved
Currently we don't have any examples related to |
…vice.java Co-authored-by: Niveathika <[email protected]>
ThisaruGuruge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose
Fixes: ballerina-platform/ballerina-library#8078
Checklist