Fix: metric-server chart rbac #1253
Open
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced .Values.rbac.create with .Values.rbac.enabled used in IF statements in several templates to match default Values and other templates.
Changed README.md to match changes and describe proper usage of a chart
What's in this PR?
There is en issue with deploying metrics-server chart with default values, in some templates value rbac.enabled is used but in others rbac.create. This is confusing and rbac,create is not in default values. This PR cleans that up by making all templates use rbac.enabled.
Why?
Paragraph above explains it
Checklist