Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thanos termination grace period seconds add #1347

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion thanos/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ keywords:
sources:
- https://github.com/thanos-io/thanos
- https://github.com/banzaicloud/banzai-charts/tree/master/thanos
version: 0.4.9
version: 0.4.10
icon: https://raw.githubusercontent.com/thanos-io/thanos/master/docs/img/Thanos-logo_fullmedium.png
maintainers:
- name: Banzai Cloud
Expand Down
3 changes: 3 additions & 0 deletions thanos/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,7 @@ These values are just samples, for more fine-tuning please check the values.yaml
| store.serviceAccount | Name of the Kubernetes service account to use | "" |
| store.livenessProbe | Set up liveness probe for store available for Thanos v0.8.0+) | {} |
| store.readinessProbe | Set up readinessProbe for store (available for Thanos v0.8.0+) | {} |
| store.terminationGracePeriodSeconds | Set up terminationGracePeriodSeconds for store - default in kubernetes is 30 | "" |
| timePartioning | list of min/max time for store partitions. See more details below. Setting this will create mutlipale thanos store deployments based on the number of items in the list | [{min: "", max: ""}] |
| hashPartioning.shards | The number of shared used to partition the blocks based on the hashmod of the blocks. Can not be used with time partitioning | "" |
| initContainers | InitContainers allows injecting specialized containers that run before app containers. This is meant to pre-configure and tune mounted volume permissions. | [] |
Expand Down Expand Up @@ -265,6 +266,7 @@ timePartioning:
| query.rbac.enabled | Enable RBAC to use the PSP | false |
| query.livenessProbe | Set up liveness probe for query | {} |
| query.readinessProbe | Set up readinessProbe for query | {} |
| query.terminationGracePeriodSeconds | Set up terminationGracePeriodSeconds for query - default in kubernetes is 30 | "" |

## Rule
|Name|Description| Default Value|
Expand Down Expand Up @@ -356,6 +358,7 @@ timePartioning:
| queryFrontend.cache.validity | | `` |
| queryFrontend.log.request.decision | Request Logging for logging the start and end of requests | `LogFinishCall` |
| queryFrontend.serviceAccountAnnotations | Optional annotations to be added to the ServiceAccount | {} |
| queryFrontend.terminationGracePeriodSeconds | Set up terminationGracePeriodSeconds for query frontend - default in kubernetes is 30 | "" |

## Contributing
Contributions are very welcome!
3 changes: 3 additions & 0 deletions thanos/templates/query-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,9 @@ spec:
{{- with .Values.query.securityContext }}
securityContext: {{ toYaml . | nindent 8 }}
{{- end }}
{{- with .Values.query.terminationGracePeriodSeconds }}
terminationGracePeriodSeconds: {{ . }}
{{- end }}
{{- with .Values.query.nodeSelector }}
nodeSelector: {{ toYaml . | nindent 8 }}
{{- end }}
Expand Down
3 changes: 3 additions & 0 deletions thanos/templates/query-frontend-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,9 @@ spec:
{{- with .Values.queryFrontend.securityContext }}
securityContext: {{ toYaml . | nindent 8 }}
{{- end }}
{{- with .Values.queryFrontend.terminationGracePeriodSeconds }}
terminationGracePeriodSeconds: {{ . }}
{{- end }}
{{- with .Values.queryFrontend.nodeSelector }}
nodeSelector: {{ toYaml . | nindent 8 }}
{{- end }}
Expand Down
3 changes: 3 additions & 0 deletions thanos/templates/store-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,9 @@ spec:
{{- with $root.Values.store.securityContext }}
securityContext: {{ toYaml . | nindent 8 }}
{{- end }}
{{- with $root.Values.store.terminationGracePeriodSeconds }}
terminationGracePeriodSeconds: {{ . }}
{{- end }}
{{- with $root.Values.store.nodeSelector }}
nodeSelector: {{ toYaml . | nindent 8 }}
{{- end }}
Expand Down
2 changes: 1 addition & 1 deletion thanos/values.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
image:
repository: quay.io/thanos/thanos
tag: v0.17.1
tag: v0.28.1
pullPolicy: IfNotPresent

store:
Expand Down