Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EditorConfig, fix formatting, remove unuses usings etc #192

Closed
wants to merge 3 commits into from

Conversation

Saibamen
Copy link
Contributor

@Saibamen Saibamen commented Feb 4, 2024

  1. Add EditorConfig from https://github.com/dotnet/aspnetcore repo
  2. Sort and remove unused usings
  3. var
  4. Fix formatting
  5. Remove trailing whitespaces
  6. Add missing readonly
  7. Avoid unnecessary assignment of value
  8. Object initialization
  9. Fix some private variable names
  10. Remove unused GetFontSize
  11. Remove redundant ToString() - this will also fix possible NREs
  12. Curly braces to surround blocks of code
  13. Convert to file-scoped namespace to reduce nesting
  14. And more

Please hide spaces in diff for better CR experience:

image

@barnhill
Copy link
Owner

barnhill commented Feb 4, 2024

I can't review this since it touches almost every line

@Saibamen
Copy link
Contributor Author

Saibamen commented Feb 4, 2024

OK, I created #194

@Saibamen Saibamen closed this Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants