fix types for unsafeDeposit and add test #24
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue with the types for
writeUnsafeDepositTransaction
was not allowingvalue
to be passed. I solved this by making the types less generic, which I think is good.Note: now value is required to be passed. We should think about how to distinguish the args.value from the top level value. The latter being the amount that will be minted on L2, the former being the mint that will be sent as msg.value in the call