Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unnecessary Number conversion for dstChain #108

Merged
merged 1 commit into from
Feb 22, 2025

Conversation

barajeel
Copy link
Contributor

Noticed that config.dstChain was being wrapped with Number(), but this conversion isn't needed. If dstChain is already a string (e.g., a network identifier), there's no reason to cast it.

The check now correctly logs the value as it is, making the code more consistent with how src and l1 chains are handled.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Feb 21, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@jackchuma jackchuma merged commit 7031c59 into base:main Feb 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants