Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix incorrect argument passing in Solidity function call #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fragchain
Copy link

I noticed that the function _getSalt was being called with named arguments ({config: config, salt: salt}), which is not supported in Solidity. This would cause a compilation error. I've updated the code to pass the arguments in the correct order, as required by Solidity. The corrected line now looks like this:

(bool alreadyDeployed, address accountAddress) =
    LibClone.createDeterministicERC1967(msg.value, implementation, _getSalt(config, salt));

This change ensures the code compiles without errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant