-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Polish #1815
base: master
Are you sure you want to change the base?
UI Polish #1815
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@mindapivessa is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
🟡 Heimdall Review Status
|
</Link> | ||
. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo? think this is an extraneous period
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's either remove or put on line 39 so it's part of the link
Builders | ||
</Title> | ||
<span className="text-sm text-dark-palette-foregroundMuted "> | ||
{/* use tracking-wide to temporary offset the odd tight letter-spacing */} | ||
<p className="text-sm text-dark-palette-foregroundMuted tracking-wide"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why p tags here instead of spans?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was hoping to fix the tracking using it since p was used for minicard that has the correct tracking. It doesn't change anything. I can change it back to span if you think that's better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gotcha. don't have a strong feeling, was just curious. if the p tags are working for you fine to keep that way
What changed? Why?
These changes collectively aim to improve the user interface and maintain a consistent design language throughout the application. Please review the changes and provide feedback.
Notes to reviewers
How has it been tested?
Locally - both on mobile and desktop