-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add app accounts sdk docs #1820
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@cb-jake is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
🟡 Heimdall Review Status
|
## Technical Details | ||
|
||
- Smart Wallet Ownership: The user's Smart Wallet acts as an owner of the app account, allowing it to manage and control the app-specific account. | ||
- Key Agnostic: App Accounts are designed to be key agnostic. They leverage our Linked Accounts technology, which supports various key types including in-browser CryptoKeys, Passkeys, and server signer products. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Linked Accounts technology" to be eventually replaced with EIP-XXXX?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
including, but not limited to, in-browser CryptoKeys, Passkeys, traditional EOAs, and server wallets products.
## Technical Details | ||
|
||
- Smart Wallet Ownership: The user's Smart Wallet acts as an owner of the app account, allowing it to manage and control the app-specific account. | ||
- Key Agnostic: App Accounts are designed to be key agnostic. They leverage our Linked Accounts technology, which supports various key types including in-browser CryptoKeys, Passkeys, and server signer products. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need a page on different signers types, and the reasons why you as a developer might want to use different ones based your app's use case
type: 'account', | ||
data: { | ||
address: '0x...', | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
based on what's being passed togetSigner
in the SDK above, wouldn't only this provided signer make sense in this example?
}); | ||
``` | ||
|
||
## Example (using an existing app account) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using an existing and deployed app account
What changed? Why?
This PR introduces App Account Docs for the Coinbase Wallet SDK
Notes to reviewers
This is a draft to introduce docs. Once the EIP is fleshed out, the overview will be updated and the new supported RPCs will be defined in their own section
How has it been tested?