Skip to content

chore: fix and improve FeedbackWidget removal regex #2151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

santamasa
Copy link

What changed? Why?

I updated the regular expressions used to remove FeedbackWidget from the code.
The previous patterns weren’t handling all edge cases, such as when there are other imports or attributes in the component.
The new regexes are more reliable and correctly remove the widget in various scenarios.

Notes to reviewers

The changes mainly affect how the FeedbackWidget is removed from both import statements and JSX components.
The new regexes ensure more robust matching and account for possible variations in the code.

How has it been tested?

These changes have been tested locally by running the script on several markdown and MDX files. No errors were encountered, and the widget was removed as expected.

Have you tested the following pages?

BaseWeb

  • [] base.org
  • [] base.org/names
  • [] base.org/builders
  • [] base.org/ecosystem
  • [] base.org/name/jesse
  • [] base.org/manage-names
  • [] base.org/resources

BaseDocs

  • [] docs.base.org
  • [] docs sub-pages

Copy link

vercel bot commented Apr 2, 2025

@santamasa is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@wbnns wbnns added the base web review To be reviewed by the Base web team label Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base web review To be reviewed by the Base web team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants