feat: basename renewals #2227
Draft
feat: basename renewals #2227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🟡 Heimdall Review Status
|
| // Params | ||
| const normalizedName = normalizeEnsDomainName(name); | ||
| const { basePrice, premiumPrice } = useRentPrice(normalizedName, years); | ||
| const totalPrice = basePrice + premiumPrice; |
There was a problem hiding this comment.
A renewal will only ever use the base price. Premiums are only used when a name is being registered and might be in a dutch auction.
There was a problem hiding this comment.
ack, i'll either only use baseprice here or see if we have a hook that only pulls baseprice
Comment on lines
31
to
33
| function secondsInYears(years: number): bigint { | ||
| const secondsPerYear = 365.25 * 24 * 60 * 60; // .25 accounting for leap years | ||
| return BigInt(Math.round(years * secondsPerYear)); |
There was a problem hiding this comment.
Want to swap this call out to the shared util?
There was a problem hiding this comment.
yeah, there are a bunch to dedupe, i'll handle that once we get the renewals working
brendan-defi
force-pushed
the
feat/renew-basenames
branch
from
43ebd3a to
d6dfc2f
Compare
brendan-defi
commented
Apr 18, 2025
Comment on lines
+102
to
+111
| return Promise.resolve(); | ||
| }, | ||
| reverseRecord: false, | ||
| setReverseRecord: function () { | ||
| return undefined; | ||
| }, | ||
| hasExistingBasename: false, | ||
| registerNameIsPending: false, | ||
| registerNameError: null, | ||
| code: undefined, |
There was a problem hiding this comment.
add all empty values to default context
brendan-defi
commented
Apr 18, 2025
| @@ -28,7 +39,7 @@ export function useRegisterNameCallback( | |||
| years: number, | |||
| discountKey?: `0x${string}`, | |||
| validationData?: `0x${string}`, | |||
| ) { | |||
| ): UseRegisterNameCallbackReturnType { | |||
There was a problem hiding this comment.
fix type issue
brendan-defi
commented
Apr 18, 2025
| @@ -61,7 +72,7 @@ export function useRegisterNameCallback( | |||
| transactionStatus: registerNameStatus, | |||
| transactionIsLoading: registerNameIsLoading, | |||
| transactionError: registerNameError, | |||
| } = useWriteContractWithReceipt({ | |||
| } = useWriteContractWithReceipt<typeof REGISTER_CONTRACT_ABI, 'register'>({ | |||
There was a problem hiding this comment.
fix type issue
brendan-defi
commented
Apr 18, 2025
Comment on lines
+40
to
+50
| type ContractFunctionPayableInfo<TAbi extends Abi, TFunctionName extends string> = Extract< | ||
| TAbi[number], | ||
| { name: TFunctionName; stateMutability: string } | ||
| >['stateMutability'] extends 'payable' | ||
| ? { value: bigint | undefined } | ||
| : { value?: never }; | ||
|
|
||
| type WriteContractParameters< | ||
| TAbi extends Abi = Abi, | ||
| TFunctionName extends string = string, | ||
| > = ContractFunctionParameters & ContractFunctionPayableInfo<TAbi, TFunctionName>; |
There was a problem hiding this comment.
add value parameter to methods with stateMutability: payable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Notes to reviewers
How has it been tested?
Have you tested the following pages?
BaseWeb
BaseDocs