Allow piping into kamal exec #1485 #1544
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also adding helpers to simulate STDIN being tty or file
|
Hi @djmb, Do you have any comments? Is there anything I can do to make this easier for you to review? |
|
This is a very welcome change. It enables me to perform all common management tasks through kamal aliases, instead of just a subset. Hopefully it gets merged soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables data to be piped to remote commands via STDIN.
An example use case would be to restore a database backup from your local dev machine:
kamal accessory exec -i --reuse mysql 'mysql example_db"' < example_db_backup.sqlAs discussed in #1485, the implementation for interactive mode now checks if STDIN is connected to a TTY and only then it uses the current '-it' options for docker, else it uses '-i', which enables the transfer of data via STDIN.
The implementation should be straight forward, just the tests were a bit tricky.
I made sure the tests also still work when not run from a tty (eg within CI).
I hope it's OK like this, any comments are welcome.