Restore Missing fileInputId Property and Add acceptedFileTypes Property#1089
Open
chadrschroeder wants to merge 4 commits intobasecamp:mainfrom
Open
Restore Missing fileInputId Property and Add acceptedFileTypes Property#1089chadrschroeder wants to merge 4 commits intobasecamp:mainfrom
chadrschroeder wants to merge 4 commits intobasecamp:mainfrom
Conversation
afcapel
suggested changes
Sep 19, 2023
Contributor
afcapel
left a comment
afcapel
left a comment
There was a problem hiding this comment.
There are a couple of styling issues, but the changes make sense. If you can fix them I'll merge.
src/trix/config/input.js
Outdated
| const input = { | ||
| level2Enabled: true, | ||
| fileInputId: `trix-file-input-${Date.now().toString(16)}`, | ||
| acceptedFileTypes: '*', |
Contributor
There was a problem hiding this comment.
We prefer double quotes for strings. The linter should flag this.
Author
|
Thanks for the quick review before. Let me know if there's anything else you want me to update here. It looks like the most recent tests failed but in a way that is unrelated to my changes. |
|
Is this okay to merge @afcapel ? |
Contributor
|
@ghiculescu I afraid I don’t maintain Trix anymore, so that ‘s up to the new maintainers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1088 by restoring the missing
fileInputIdproperty.Also adds an
acceptedFileTypesproperty, similar to what was proposed in #789. That PR was opened over 3 years ago back when this code was still using CoffeeScript. I've implemented a similar change here in JavaScript, but I set this up as a simple string attribute value instead of an array. Let me know if you'd rather not have this option, but this is why I was trying to override thepickFilesfunction in the first place.