Define TrixToolbarElement.editorElements property#1127
Merged
jorgemanrubia merged 1 commit intobasecamp:mainfrom Oct 8, 2025
Merged
Define TrixToolbarElement.editorElements property#1127jorgemanrubia merged 1 commit intobasecamp:mainfrom
TrixToolbarElement.editorElements property#1127jorgemanrubia merged 1 commit intobasecamp:mainfrom
Conversation
Open
seanpdoyle
force-pushed
the
trix-toolbar-editorElement-property
branch
2 times, most recently
from
d34cf52 to
d56ec0a
Compare
Collaborator
Author
|
@afcapel could you review this? I'm imagining a use case where applications might want to set up a |
seanpdoyle
force-pushed
the
trix-toolbar-editorElement-property
branch
from
d56ec0a to
6a86202
Compare
seanpdoyle
changed the title
TrixToolbarElement.editorElementsTrixToolbarElement.editorElements property
seanpdoyle
force-pushed
the
trix-toolbar-editorElement-property
branch
from
6a86202 to
a7f0dd3
Compare
Define properties for accessing all `<trix-editor>` elements that declare a relationship with a `<trix-toolbar>` element through a `[toolbar]`-`[id]` attribute relationship. Since multiple `<trix-editor>` elements can reference a `<trix-toolbar>` element by name, this commit introduces both an `.editorElements` and `.editorElement` properties. The `.editorElement` property returns the first item in `.editorElements`, if there are any.
seanpdoyle
force-pushed
the
trix-toolbar-editorElement-property
branch
from
a7f0dd3 to
552aef6
Compare
jorgemanrubia
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define properties for accessing all
<trix-editor>elements that declare a relationship with a<trix-toolbar>element through a[toolbar]-[id]attribute relationship.Since multiple
<trix-editor>elements can reference a<trix-toolbar>element by name, this commit introduces both an.editorElementsand.editorElementproperties.The
.editorElementproperty returns the first item in.editorElements, if there are any.