ci: integration test with Action Text #1235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
flavorjones
force-pushed
the
flavorjones/rails-integration-tests
branch
3 times, most recently
from
ea5516d to
5945063
Compare
flavorjones
force-pushed
the
flavorjones/rails-integration-tests
branch
from
5945063 to
5c8ef0a
Compare
seanpdoyle
reviewed
May 14, 2025
| - name: Action Text tests | ||
| run: | | ||
| cd rails/actiontext | ||
| bundle exec rake test test:system |
There was a problem hiding this comment.
This is exciting! Nice work.
Were there any lessons learned in this process that could be applied to rails/rails? From what I recall, buildkite isn't currently executing the System Test suite for Action Text as part of CI runs.
There was a problem hiding this comment.
@seanpdoyle I don't think I have anything to add to those threads, which seem related at various points to Buildkite, container networking, karma browser coverage, and selenium configuration. I don't know much about any of those things!
By default, Action Text's system tests will use headless chrome, which is installed on the Github Actions runner so it Just Worked™ for me for this limited use case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.