Skip to content

Make type hints conform ruff #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Apr 15, 2025
Merged

Make type hints conform ruff #151

merged 32 commits into from
Apr 15, 2025

Conversation

c-w-feldmann
Copy link
Collaborator

@c-w-feldmann c-w-feldmann commented Apr 14, 2025 •
edited
Loading

This PR solves #150

  • Adapt type hints according to ruff formalsim

@c-w-feldmann c-w-feldmann linked an issue Apr 14, 2025 that may be closed by this pull request
Make type hints conform ruff #150
Closed
@c-w-feldmann c-w-feldmann self-assigned this Apr 14, 2025
@c-w-feldmann c-w-feldmann force-pushed the 150-make-type-hints-conform-ruff branch from e0ece66 to e559f20 Compare April 14, 2025 16:46
@c-w-feldmann c-w-feldmann added the type: maintenance Improvement of code or keeping the code up to date label Apr 14, 2025
@c-w-feldmann
Copy link
Collaborator Author

@JochenSiegWork Mostly typehints and corresponding docstring.
Only real change happend here, where I replaced the default value with None and set it to the old value in the init.

JochenSiegWork
JochenSiegWork requested changes Apr 15, 2025
View reviewed changes
Copy link
Collaborator

@JochenSiegWork JochenSiegWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I only found one typo.

@c-w-feldmann c-w-feldmann marked this pull request as ready for review April 15, 2025 07:38
@c-w-feldmann c-w-feldmann merged commit 1ea5e02 into main Apr 15, 2025
19 checks passed
@c-w-feldmann c-w-feldmann deleted the 150-make-type-hints-conform-ruff branch April 15, 2025 07:39
c-w-feldmann added a commit that referenced this pull request Apr 17, 2025
@c-w-feldmann
Make type hints conform ruff (#151)
f7acc4e 
* Autofix type hints
* Manual reworking of docstrings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JochenSiegWork JochenSiegWork JochenSiegWork approved these changes

Assignees

@c-w-feldmann c-w-feldmann

Labels
type: maintenance Improvement of code or keeping the code up to date
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make type hints conform ruff
2 participants
@c-w-feldmann @JochenSiegWork