Skip to content

Restore mode #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Restore mode #374

merged 4 commits into from
Sep 23, 2024

Conversation

bashtage
Copy link
Owner

No description provided.

@pep8speaks
Copy link

Hello @bashtage! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 712:29: E203 whitespace before ':'

with pytest.warns(FutureWarning):
self.setup_bitgenerator([0], mode="sequence")

def setup_bitgenerator(self, seed, mode=None):

Check notice

Code scanning / CodeQL

Mismatch between signature and use of an overridden method Note test

Overridden method signature does not match
call
, where it is passed an argument named 'inc'. Overriding method
method TestPCG64XSLRR.setup_bitgenerator
matches the call.
Overridden method signature does not match
call
, where it is passed an argument named 'inc'. Overriding method
method TestPCG64XSLRR.setup_bitgenerator
matches the call.
Overridden method signature does not match
call
, where it is passed an argument named 'inc'. Overriding method
method TestPCG64XSLRR.setup_bitgenerator
matches the call.
Overridden method signature does not match
call
, where it is passed an argument named 'inc'. Overriding method
method TestPCG64XSLRR.setup_bitgenerator
matches the call.
Overridden method signature does not match
call
, where it is passed an argument named 'inc'. Overriding method
method TestPCG64XSLRR.setup_bitgenerator
matches the call.
Overridden method signature does not match
call
, where it is passed an argument named 'inc'. Overriding method
method TestPCG64DXSM.setup_bitgenerator
matches the call.
Overridden method signature does not match call, where it is passed an argument named 'counter'. Overriding method method TestSquares.setup_bitgenerator matches the call.
@bashtage bashtage merged commit 2f25051 into main Sep 23, 2024
14 of 24 checks passed
@bashtage bashtage deleted the restore-mode branch September 23, 2024 11:07
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 97.22222% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.05%. Comparing base (434e3da) to head (a4f2509).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
randomgen/_deprecated_value.py 80.00% 1 Missing and 1 partial ⚠️
randomgen/pcg64.pyx 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #374      +/-   ##
==========================================
+ Coverage   89.95%   90.05%   +0.09%     
==========================================
  Files          50       51       +1     
  Lines        7886     7955      +69     
  Branches      489      493       +4     
==========================================
+ Hits         7094     7164      +70     
+ Misses        760      759       -1     
  Partials       32       32              
Flag Coverage Δ
90.04% <97.22%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants