Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #215 #231

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix issue #215 #231

wants to merge 1 commit into from

Conversation

xchangfeng
Copy link

Add windivert_log.mc to SOURCES to fix error:"Not Found windivert_log.rc or 'windivert_log.h in source code!"

Add windivert_log.mc to SOURCES to fix error:"Not Found windivert_log.rc or 'windivert_log.h in source code!"
@CLAassistant
Copy link

CLAassistant commented Apr 9, 2020

CLA assistant check
All committers have signed the CLA.

@xchangfeng xchangfeng changed the title Fix issue#215 Fix issue #215 Apr 13, 2020
@basil00
Copy link
Owner

basil00 commented Apr 13, 2020

Is the SOURCES file even used? I thought it was redundant since switching to the VS build. Actually, I am wondering why it was not already deleted.

@xchangfeng
Copy link
Author

I followed the guidance of https://reqrypt.org/windivert-doc.html to generate .sys files by running wddk-build.bat not VS, the problem of issue #215 happend:"Not Found windivert_log.rc or 'windivert_log.h`"

I found that when running wddk-build.bat, it finally run file /sys/sources to generate .sys files.

Because you said that I quote:"The windivert_log.rc and windivert_log.h files should be automatically built from the windivert_log.mc file. However, it appears this step is not working. Perhaps the project files are not compatible with VS2019." And I realized that 'windivert_log.mc' should be complied at first. After I added 'windivert_log.mc' to 'SOURCES', the problem was solved and the drvier WinDivert64.sys or WinDivert32.sys was generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants