Glances #807
Open
Glances #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastienwirtz
requested changes
Oct 19, 2024
There was a problem hiding this comment.
Thanks for your contribution @mq1! A glance custom card will be a very nice addition.
| } | ||
| }) | ||
| .catch((e) => { | ||
| this.percentage = "Error fetching data"; |
There was a problem hiding this comment.
It would be great to have that in a separate error var.
Comment on lines
+37
to
+42
| if (this.item.stat === "cpu") { | ||
| this.percentage = response.total; | ||
| } | ||
| if (this.item.stat === "mem") { | ||
| this.percentage = response.percent; | ||
| } |
There was a problem hiding this comment.
It could be great is stat was in fact stats and accepts a comma separated list of stat so we could display multiple stat in one card. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds basic CPU and Memory monitor widgets using a Glances server
Type of change
Checklist:
config.ymlfileI just noticed my IDE formatted the customservices.md automatically, do these changes need to be reverted?