warning: variables can be used directly in the `format!` string
  --> pm64/src/sbn/de.rs:62:13
   |
62 | /             warn!(
63 | |                 "size mismatch! SBN says it is {:#X} B but the input is {:#X} B",
64 | |                 internal_size, true_size
65 | |             );
   | |_____________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args

warning: variables can be used directly in the `format!` string
  --> pm64/src/sbn/de.rs:28:34
   |
28 |             Error::Io(source) => write!(f, "{}", source),
   |                                  ^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
   |
28 -             Error::Io(source) => write!(f, "{}", source),
28 +             Error::Io(source) => write!(f, "{source}"),
   |

warning: calling .bytes() is very inefficient when data is not in memory
  --> pm64/src/rw.rs:64:39
   |
64 |         let buffer: Result<Vec<u8>> = self.take(max_len).bytes().collect();
   |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: consider using `BufReader`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unbuffered_bytes
   = note: `#[warn(clippy::unbuffered_bytes)]` on by default

warning: using `SeekFrom::Current` to start from current position
  --> pm64/src/rw.rs:10:9
   |
10 |         self.seek(SeekFrom::Current(0))
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.stream_position()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#seek_from_current
   = note: `#[warn(clippy::seek_from_current)]` on by default

warning: this `map_or` can be simplified
   --> pm64/src/bgm/cmd.rs:839:23
    |
839 |                 while self.seq.peek().map_or(false, |(t, _)| *t == time) {
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
    = note: `#[warn(clippy::unnecessary_map_or)]` on by default
help: use is_some_and instead
    |
839 -                 while self.seq.peek().map_or(false, |(t, _)| *t == time) {
839 +                 while self.seq.peek().is_some_and(|(t, _)| *t == time) {
    |

warning: casting to the same type is unnecessary (`usize` -> `usize`)
   --> pm64/src/bgm/cmd.rs:803:42
    |
803 |                     self.current_time += *delta_time as usize;
    |                                          ^^^^^^^^^^^^^^^^^^^^ help: try: `*delta_time`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

warning: casting to the same type is unnecessary (`usize` -> `usize`)
   --> pm64/src/bgm/cmd.rs:441:33
    |
441 |                 current_time += *delta_time as usize;
    |                                 ^^^^^^^^^^^^^^^^^^^^ help: try: `*delta_time`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

warning: casting to the same type is unnecessary (`usize` -> `usize`)
   --> pm64/src/bgm/cmd.rs:270:55
    |
270 |             Command::Delay { value: delta } => time + delta as usize,
    |                                                       ^^^^^^^^^^^^^^ help: try: `delta`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

warning: casting to the same type is unnecessary (`usize` -> `usize`)
   --> pm64/src/bgm/cmd.rs:257:25
    |
257 |                 time += *delta_time as usize;
    |                         ^^^^^^^^^^^^^^^^^^^^ help: try: `*delta_time`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

warning: variables can be used directly in the `format!` string
   --> pm64/src/bgm/midi.rs:518:30
    |
518 |             let name_lower = format!("{:?} {:?}", track_name, instrument_name).to_lowercase();
    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
518 -             let name_lower = format!("{:?} {:?}", track_name, instrument_name).to_lowercase();
518 +             let name_lower = format!("{track_name:?} {instrument_name:?}").to_lowercase();
    |

warning: variables can be used directly in the `format!` string
   --> pm64/src/bgm/midi.rs:464:29
    |
464 | ...                   log::debug!("bpm: {}", beats_per_minute);
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
464 -                             log::debug!("bpm: {}", beats_per_minute);
464 +                             log::debug!("bpm: {beats_per_minute}");
    |

warning: casting to the same type is unnecessary (`usize` -> `usize`)
   --> pm64/src/bgm/midi.rs:430:74
    |
430 | ...                   length: convert_time(length as usize, time_divisor) as u16,
    |                                            ^^^^^^^^^^^^^^^ help: try: `length`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
    = note: `#[warn(clippy::unnecessary_cast)]` on by default

warning: variables can be used directly in the `format!` string
   --> pm64/src/bgm/midi.rs:304:41
    |
304 | ...                   log::warn!("found NoteOn(vel=0) {} but saw no NoteOn(vel>0)", key);
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
304 -                                         log::warn!("found NoteOn(vel=0) {} but saw no NoteOn(vel>0)", key);
304 +                                         log::warn!("found NoteOn(vel=0) {key} but saw no NoteOn(vel>0)");
    |

warning: variables can be used directly in the `format!` string
   --> pm64/src/bgm/midi.rs:279:37
    |
279 | ...                   log::warn!("found NoteOff {} but saw no NoteOn", key);
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
279 -                                     log::warn!("found NoteOff {} but saw no NoteOn", key);
279 +                                     log::warn!("found NoteOff {key} but saw no NoteOn");
    |

warning: accessing first element with `smf.tracks.get(0)`
  --> pm64/src/bgm/midi.rs:65:17
   |
65 |                 smf.tracks.get(0),
   |                 ^^^^^^^^^^^^^^^^^ help: try: `smf.tracks.first()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
   = note: `#[warn(clippy::get_first)]` on by default

warning: variables can be used directly in the `format!` string
  --> pm64/src/bgm/midi.rs:59:5
   |
59 |     log::debug!("song length: {} ticks (48 ticks/beat)", total_song_length);
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
   |
59 -     log::debug!("song length: {} ticks (48 ticks/beat)", total_song_length);
59 +     log::debug!("song length: {total_song_length} ticks (48 ticks/beat)");
   |

warning: variables can be used directly in the `format!` string
  --> pm64/src/bgm/midi.rs:33:5
   |
33 |     log::debug!("original ticks/beat: {}", ticks_per_beat);
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
   |
33 -     log::debug!("original ticks/beat: {}", ticks_per_beat);
33 +     log::debug!("original ticks/beat: {ticks_per_beat}");
   |

warning: iterating on a map's values
   --> pm64/src/bgm/de.rs:598:9
    |
598 |         map.0.into_iter().map(|(_, cmd)| cmd).collect()
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `map.0.into_values()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map
    = note: `#[warn(clippy::iter_kv_map)]` on by default

warning: manual backwards iteration
   --> pm64/src/bgm/de.rs:589:20
    |
589 |               .iter()
    |  ____________________^
590 | |             .rev()
591 | |             .next() //self.0.last_key_value()
    | |___________________^ help: use: `.next_back()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_next_back
    = note: `#[warn(clippy::manual_next_back)]` on by default

warning: variables can be used directly in the `format!` string
   --> pm64/src/bgm/de.rs:570:36
    |
570 |                 let id: MarkerId = format!("Offset {:#X}", offset);
    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
570 -                 let id: MarkerId = format!("Offset {:#X}", offset);
570 +                 let id: MarkerId = format!("Offset {offset:#X}");
    |

warning: transmute used without annotations
   --> pm64/src/bgm/de.rs:287:43
    |
287 | ...                   std::mem::transmute(tracks)
    |                                 ^^^^^^^^^ help: consider adding missing annotations: `transmute::<[std::mem::MaybeUninit<bgm::Track>; 16], [bgm::Track; 16]>`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations
    = note: `#[warn(clippy::missing_transmute_annotations)]` on by default

warning: variables can be used directly in the `format!` string
   --> pm64/src/bgm/de.rs:255:17
    |
255 |                 debug!("tracks start = {:#X} (offset = {:#X})", track_list_pos, offset);
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
255 -                 debug!("tracks start = {:#X} (offset = {:#X})", track_list_pos, offset);
255 +                 debug!("tracks start = {track_list_pos:#X} (offset = {offset:#X})");
    |

warning: variables can be used directly in the `format!` string
   --> pm64/src/bgm/de.rs:231:13
    |
231 |             warn!("unused data at {:#X}", furthest_read_pos);
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
231 -             warn!("unused data at {:#X}", furthest_read_pos);
231 +             warn!("unused data at {furthest_read_pos:#X}");
    |

warning: useless conversion to the same type: `std::ops::Range<u16>`
   --> pm64/src/bgm/de.rs:220:31
    |
220 |               bgm.instruments = (0..voices_count)
    |  _______________________________^
221 | |                 .into_iter()
    | |____________________________^ help: consider removing `.into_iter()`: `(0..voices_count)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion