fix LoopHandles being active by default #129
clippy
28 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 28 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.88.0-nightly (13e879094 2025-05-04)
- cargo 1.88.0-nightly (7918c7eb5 2025-04-27)
- clippy 0.1.88 (13e8790949 2025-05-04)
Annotations
Check warning on line 78 in mamar-wasm-bridge/src/lib.rs
github-actions / clippy
variables can be used directly in the `format!` string
warning: variables can be used directly in the `format!` string
--> mamar-wasm-bridge/src/lib.rs:78:5
|
78 | log::info!("bgm_add_voice {:?}", bgm);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `#[warn(clippy::uninlined_format_args)]` on by default
help: change this to
|
78 - log::info!("bgm_add_voice {:?}", bgm);
78 + log::info!("bgm_add_voice {bgm:?}");
|
Check warning on line 23 in pm64/src/main.rs
github-actions / clippy
variables can be used directly in the `format!` string
warning: variables can be used directly in the `format!` string
--> pm64/src/main.rs:23:17
|
23 | println!("{:?}", instrument);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `#[warn(clippy::uninlined_format_args)]` on by default
help: change this to
|
23 - println!("{:?}", instrument);
23 + println!("{instrument:?}");
|
Check warning on line 65 in pm64/src/sbn/de.rs
github-actions / clippy
variables can be used directly in the `format!` string
warning: variables can be used directly in the `format!` string
--> pm64/src/sbn/de.rs:62:13
|
62 | / warn!(
63 | | "size mismatch! SBN says it is {:#X} B but the input is {:#X} B",
64 | | internal_size, true_size
65 | | );
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
Check warning on line 28 in pm64/src/sbn/de.rs
github-actions / clippy
variables can be used directly in the `format!` string
warning: variables can be used directly in the `format!` string
--> pm64/src/sbn/de.rs:28:34
|
28 | Error::Io(source) => write!(f, "{}", source),
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
28 - Error::Io(source) => write!(f, "{}", source),
28 + Error::Io(source) => write!(f, "{source}"),
|
Check warning on line 64 in pm64/src/rw.rs
github-actions / clippy
calling .bytes() is very inefficient when data is not in memory
warning: calling .bytes() is very inefficient when data is not in memory
--> pm64/src/rw.rs:64:39
|
64 | let buffer: Result<Vec<u8>> = self.take(max_len).bytes().collect();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider using `BufReader`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unbuffered_bytes
= note: `#[warn(clippy::unbuffered_bytes)]` on by default
Check warning on line 839 in pm64/src/bgm/cmd.rs
github-actions / clippy
this `map_or` can be simplified
warning: this `map_or` can be simplified
--> pm64/src/bgm/cmd.rs:839:23
|
839 | while self.seq.peek().map_or(false, |(t, _)| *t == time) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
= note: `#[warn(clippy::unnecessary_map_or)]` on by default
help: use is_some_and instead
|
839 - while self.seq.peek().map_or(false, |(t, _)| *t == time) {
839 + while self.seq.peek().is_some_and(|(t, _)| *t == time) {
|
Check warning on line 517 in pm64/src/bgm/midi.rs
github-actions / clippy
variables can be used directly in the `format!` string
warning: variables can be used directly in the `format!` string
--> pm64/src/bgm/midi.rs:517:30
|
517 | let name_lower = format!("{:?} {:?}", track_name, instrument_name).to_lowercase();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
517 - let name_lower = format!("{:?} {:?}", track_name, instrument_name).to_lowercase();
517 + let name_lower = format!("{track_name:?} {instrument_name:?}").to_lowercase();
|
Check warning on line 463 in pm64/src/bgm/midi.rs
github-actions / clippy
variables can be used directly in the `format!` string
warning: variables can be used directly in the `format!` string
--> pm64/src/bgm/midi.rs:463:29
|
463 | ... log::debug!("bpm: {}", beats_per_minute);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
463 - log::debug!("bpm: {}", beats_per_minute);
463 + log::debug!("bpm: {beats_per_minute}");
|
Check warning on line 303 in pm64/src/bgm/midi.rs
github-actions / clippy
variables can be used directly in the `format!` string
warning: variables can be used directly in the `format!` string
--> pm64/src/bgm/midi.rs:303:41
|
303 | ... log::warn!("found NoteOn(vel=0) {} but saw no NoteOn(vel>0)", key);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
303 - log::warn!("found NoteOn(vel=0) {} but saw no NoteOn(vel>0)", key);
303 + log::warn!("found NoteOn(vel=0) {key} but saw no NoteOn(vel>0)");
|
Check warning on line 278 in pm64/src/bgm/midi.rs
github-actions / clippy
variables can be used directly in the `format!` string
warning: variables can be used directly in the `format!` string
--> pm64/src/bgm/midi.rs:278:37
|
278 | ... log::warn!("found NoteOff {} but saw no NoteOn", key);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
278 - log::warn!("found NoteOff {} but saw no NoteOn", key);
278 + log::warn!("found NoteOff {key} but saw no NoteOn");
|
Check warning on line 58 in pm64/src/bgm/midi.rs
github-actions / clippy
variables can be used directly in the `format!` string
warning: variables can be used directly in the `format!` string
--> pm64/src/bgm/midi.rs:58:5
|
58 | log::debug!("song length: {} ticks (48 ticks/beat)", total_song_length);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
58 - log::debug!("song length: {} ticks (48 ticks/beat)", total_song_length);
58 + log::debug!("song length: {total_song_length} ticks (48 ticks/beat)");
|
Check warning on line 32 in pm64/src/bgm/midi.rs
github-actions / clippy
variables can be used directly in the `format!` string
warning: variables can be used directly in the `format!` string
--> pm64/src/bgm/midi.rs:32:5
|
32 | log::debug!("original ticks/beat: {}", ticks_per_beat);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
32 - log::debug!("original ticks/beat: {}", ticks_per_beat);
32 + log::debug!("original ticks/beat: {ticks_per_beat}");
|
Check warning on line 566 in pm64/src/bgm/de.rs
github-actions / clippy
variables can be used directly in the `format!` string
warning: variables can be used directly in the `format!` string
--> pm64/src/bgm/de.rs:566:36
|
566 | let id: MarkerId = format!("Offset {:#X}", offset);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
566 - let id: MarkerId = format!("Offset {:#X}", offset);
566 + let id: MarkerId = format!("Offset {offset:#X}");
|
Check warning on line 251 in pm64/src/bgm/de.rs
github-actions / clippy
variables can be used directly in the `format!` string
warning: variables can be used directly in the `format!` string
--> pm64/src/bgm/de.rs:251:17
|
251 | debug!("tracks start = {:#X} (offset = {:#X})", track_list_pos, offset);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
251 - debug!("tracks start = {:#X} (offset = {:#X})", track_list_pos, offset);
251 + debug!("tracks start = {track_list_pos:#X} (offset = {offset:#X})");
|
Check warning on line 227 in pm64/src/bgm/de.rs
github-actions / clippy
variables can be used directly in the `format!` string
warning: variables can be used directly in the `format!` string
--> pm64/src/bgm/de.rs:227:13
|
227 | warn!("unused data at {:#X}", furthest_read_pos);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
227 - warn!("unused data at {:#X}", furthest_read_pos);
227 + warn!("unused data at {furthest_read_pos:#X}");
|
Check warning on line 186 in pm64/src/bgm/de.rs
github-actions / clippy
variables can be used directly in the `format!` string
warning: variables can be used directly in the `format!` string
--> pm64/src/bgm/de.rs:186:21
|
186 | debug!("segment {:#X}", pos);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
186 - debug!("segment {:#X}", pos);
186 + debug!("segment {pos:#X}");
|
Check warning on line 130 in pm64/src/bgm/de.rs
github-actions / clippy
variables can be used directly in the `format!` string
warning: variables can be used directly in the `format!` string
--> pm64/src/bgm/de.rs:127:13
|
127 | / warn!(
128 | | "size mismatch! BGM says it is {:#X} B but the input is {:#X} B",
129 | | internal_size, true_size
130 | | );
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
Check warning on line 52 in pm64/src/bgm/de.rs
github-actions / clippy
variables can be used directly in the `format!` string
warning: variables can be used directly in the `format!` string
--> pm64/src/bgm/de.rs:52:21
|
52 | write!(f, "{}", source)
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
52 - write!(f, "{}", source)
52 + write!(f, "{source}")
|
Check warning on line 47 in pm64/src/bgm/de.rs
github-actions / clippy
variables can be used directly in the `format!` string
warning: variables can be used directly in the `format!` string
--> pm64/src/bgm/de.rs:47:46
|
47 | Error::UnknownSeqCommand(cmd) => write!(f, "Unknown sequence command: {:#X}", cmd),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
47 - Error::UnknownSeqCommand(cmd) => write!(f, "Unknown sequence command: {:#X}", cmd),
47 + Error::UnknownSeqCommand(cmd) => write!(f, "Unknown sequence command: {cmd:#X}"),
|
Check warning on line 46 in pm64/src/bgm/de.rs
github-actions / clippy
variables can be used directly in the `format!` string
warning: variables can be used directly in the `format!` string
--> pm64/src/bgm/de.rs:46:50
|
46 | Error::UnknownSegmentCommand(cmd) => write!(f, "Unknown segment command: {:#X}", cmd),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
46 - Error::UnknownSegmentCommand(cmd) => write!(f, "Unknown segment command: {:#X}", cmd),
46 + Error::UnknownSegmentCommand(cmd) => write!(f, "Unknown segment command: {cmd:#X}"),
|
Check warning on line 45 in pm64/src/bgm/de.rs
github-actions / clippy
variables can be used directly in the `format!` string
warning: variables can be used directly in the `format!` string
--> pm64/src/bgm/de.rs:41:58
|
41 | Error::InvalidNumVariations(num_segments) => write!(
| __________________________________________________________^
42 | | f,
43 | | "Exactly 4 variations are supported, but this file has {}",
44 | | num_segments
45 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
Check warning on line 40 in pm64/src/bgm/de.rs
github-actions / clippy
variables can be used directly in the `format!` string
warning: variables can be used directly in the `format!` string
--> pm64/src/bgm/de.rs:36:18
|
36 | } => write!(
| __________________^
37 | | f,
38 | | "The file says it is {}B, but it is actually {}B",
39 | | internal_size, true_size
40 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
Check warning on line 188 in pm64/src/bgm/en.rs
github-actions / clippy
variables can be used directly in the `format!` string
warning: variables can be used directly in the `format!` string
--> pm64/src/bgm/en.rs:188:25
|
188 | info!("sharing tracks at {:#X}", track_data_start);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
188 - info!("sharing tracks at {:#X}", track_data_start);
188 + info!("sharing tracks at {track_data_start:#X}");
|
Check warning on line 37 in pm64/src/bgm/en.rs
github-actions / clippy
variables can be used directly in the `format!` string
warning: variables can be used directly in the `format!` string
--> pm64/src/bgm/en.rs:37:34
|
37 | Error::Io(source) => write!(f, "{}", source),
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
37 - Error::Io(source) => write!(f, "{}", source),
37 + Error::Io(source) => write!(f, "{source}"),
|
Check warning on line 35 in pm64/src/bgm/en.rs
github-actions / clippy
variables can be used directly in the `format!` string
warning: variables can be used directly in the `format!` string
--> pm64/src/bgm/en.rs:35:47
|
35 | Error::EndMarkerTooFarAway(id) => write!(f, "End marker '{:?}' is too far away from start marker", id,),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
35 - Error::EndMarkerTooFarAway(id) => write!(f, "End marker '{:?}' is too far away from start marker", id,),
35 + Error::EndMarkerTooFarAway(id) => write!(f, "End marker '{id:?}' is too far away from start marker",),
|