Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kube integration #22

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from
Open

Kube integration #22

wants to merge 11 commits into from

Conversation

JSun14
Copy link
Collaborator

@JSun14 JSun14 commented May 5, 2022

Overview

Changes

  • added kubeflow orchestrator integration

API Updates

New Features (required)

Deprecations (required)

Enhancements (required)

Checklist

  • Interrogate has > 70% coverage
  • All tests have passed (new tests are made)
  • Total test coverage > 75%
  • New code test coverage > 80%
  • Pass all linting checks

References

@bayoumi17m bayoumi17m changed the base branch from main to dev May 5, 2022 17:16
"""

# Containerize all steps using docker utils helper functions
self.image_name = Directory().active_stack.container_registry.uri + \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a \ at line 87 and 89?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't notice anything else in the files changed that looks wrong

Copy link
Collaborator

@connorjchen connorjchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks legit other than poetry files committed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants