fix: correctly find runfiles root for symlinks #2665
+76
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution. Would it be possible to add a test of some sort to check for regressions in the future? If there is no good place, feel free to create //tests/runfiles package and put it there. |
|
Let me know what you think of 2e03584! |
aignas
reviewed
Mar 21, 2025
aignas
reviewed
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$maybe_runfiles_rootdoesn't seem to be a real variable. Based on the presence of thewhileloop, it seems that this code wants to try resolving the symlink one level at a time (readlink, notrealpath) until it can find runfiles?