Skip to content

Conversation

@meteorcloudy
Copy link
Contributor

@meteorcloudy meteorcloudy commented Nov 3, 2025

Fix bcr presubmit build on windows

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @meteorcloudy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the presubmit configuration for the gazelle module by adding a batch_commands entry to the presubmit.yml file. This change is intended to correctly apply a Bazel module override for rules_python during the execution of presubmit tests, ensuring the test environment is configured as expected for Bazel builds.

Highlights

  • Presubmit Configuration: Introduced a new batch_commands section within the bcr_test_module configuration in .bcr/gazelle/presubmit.yml.
  • Bazel Module Override: The added batch_commands entry ensures that the rules_python module is overridden in the .bazelrc file during presubmit test execution, specifically by echoing common --override_module=rules_python=.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a batch_commands section to the presubmit.yml configuration. However, the new command is a duplicate of an existing one under shell_commands, which will result in a redundant configuration line being added to .bazelrc. This is likely an error and should be corrected by either removing the old command or ensuring the new one is not a duplicate.

@aignas
Copy link
Collaborator

aignas commented Nov 4, 2025

Thanks!

@aignas aignas added this pull request to the merge queue Nov 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 4, 2025
@aignas aignas added this pull request to the merge queue Nov 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 4, 2025
@aignas
Copy link
Collaborator

aignas commented Nov 4, 2025

Ah, our codebase needs to be fixed so that we can merge to main because (probably) bazel 9.0 release candidate was released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants