Move library.bzl to rules_apple_patched_imports #765
Conversation
jerrymarino
changed the title
jerrymarino
changed the title
| load("@bazel_skylib//lib:sets.bzl", "sets") | ||
| load("@bazel_skylib//lib:selects.bzl", "selects") | ||
| load("@build_bazel_rules_apple//apple:apple.bzl", "apple_dynamic_framework_import", "apple_static_framework_import") | ||
| load("//rules:apple_patched.bzl", "apple_dynamic_framework_import", "apple_static_framework_import") |
There was a problem hiding this comment.
Any chance this could slow us down in the future when trying to bump rules_apple to pick up changes that affect these symbols?
There was a problem hiding this comment.
I don't think so, we've been running with this file pretty much since the beginning of the repo.
There was a problem hiding this comment.
Is the apple_patched behavior used anywhere? It looks to me like it is dead code after we dropped Carthage/CocoaPods pre-building dependencies support. I don't think we ever exercised this code path in our consumption of rules_ios IIUC.
There was a problem hiding this comment.
Indeed AFAICT this was not being exercised? More details on your intent with this change would help.
There was a problem hiding this comment.
You've got it - I will followup with this PR in a few days, we are working through some updates to get 6.x.x really working well.
luispadron
left a comment
luispadron
left a comment
There was a problem hiding this comment.
Some more info on why this change is required would be great
No description provided.