Skip to content

Publish [email protected] #4589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

ouillie
Copy link

@ouillie ouillie commented May 14, 2025

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules (rules_wasm) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@ouillie
Copy link
Author

ouillie commented May 14, 2025

It seems to want the type of the github_user_id in metadata.template.json to be a number, but the example suggests it should be a string.

@ouillie ouillie force-pushed the rules_wasm-v2.0.0 branch from b5b011c to 3397996 Compare May 14, 2025 21:40
@ouillie ouillie force-pushed the rules_wasm-v2.0.0 branch from 3397996 to 8c710cf Compare May 14, 2025 21:42
@ouillie ouillie marked this pull request as ready for review May 14, 2025 21:59
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.

@Wyverald Wyverald added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label May 15, 2025
meteorcloudy added a commit to bazel-contrib/publish-to-bcr that referenced this pull request May 15, 2025
fmeum pushed a commit to bazel-contrib/publish-to-bcr that referenced this pull request May 15, 2025
@ouillie
Copy link
Author

ouillie commented May 16, 2025

Blocked on bytecodealliance/go-modules#346 then I'll re-open with 2.0.1

@ouillie ouillie closed this May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants