Add brotli cgo bindings module #4734
Conversation
@bazel-io skip_check unstable_url
|
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (brotli_go) have been updated in this PR. |
|
@bazel-io skip_check unstable_url |
bazel-io
added
the
skip-url-stability-check
| @@ -0,0 +1,9 @@ | |||
| { | |||
| "url": "https://github.com/google/brotli/archive/00c6df4d2f846f3d7d4fc42865af97337e9b545c.tar.gz", | |||
There was a problem hiding this comment.
This commit does not correspond to the tag with the version. This is fine for testing it in the BCR CI but shouldn't but merged as is.
I see the following alternatives:
- Wait for the next tagged release and use that instead.
- Use the tarball from the last tagged version and use patch/overlay to add the go specific parts on BCR.
- Use a pseudo-version like 0.0.0-DATE-commit like other modules do. This might be confusing and not work well when mixed with semver versions.
There was a problem hiding this comment.
Added tag go/cbrotli/v1.1.0.bcr.0. We not yet ready for next release...
|
What's stalled here? |
|
Had a detour to investigate if bazel + cgo + win is possible to fix. Concluded it is not worth it this evening. Will update PR tomorrow, so it will pass CI pipelines. |
@bazel-io skip_check unstable_url