Skip to content

Publish [email protected] #4795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 11, 2025
Merged

Conversation

WojciechMazur
Copy link
Contributor

@bazel-io
Copy link
Member

bazel-io commented Jun 9, 2025

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (gazelle_cc) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

fmeum
fmeum previously approved these changes Jun 9, 2025
@fmeum fmeum added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Jun 9, 2025
@fmeum fmeum enabled auto-merge (squash) June 9, 2025 21:50
@fmeum
Copy link
Contributor

fmeum commented Jun 9, 2025

@WojciechMazur Windows fails

auto-merge was automatically disabled June 10, 2025 19:47

Head branch was pushed to by a user without write access

@bazel-io bazel-io dismissed fmeum’s stale review June 10, 2025 19:47

Require module maintainers' approval for newly pushed changes.

@WojciechMazur
Copy link
Contributor Author

I've seen that step Setup (Shell Commands) is not present on Windows runners - maybe that's a limitation of buildkite CI or internal decision. Anyway the actual tests requires us to run these steps to generate BUILD files by our gazelle extension.

Our setup is mostly the same as in the https://github.com/bazel-contrib/bazel-gazelle/ but for some reason they seem to not have this problems. Probably, that's because presubmit is building existing targets instead of creating new ones, becouse without shell commands these were not erased.

Because of these reasons I've decided to disable testing on Windows. Building existing target would be simply fruitless.

@fmeum
Copy link
Contributor

fmeum commented Jun 10, 2025

@WojciechMazur You can use run_targets instead, which I think works on all platforms. But I can also merge as is.

…n building generated proto_library targets, however previously these were building correctly
@WojciechMazur
Copy link
Contributor Author

There were some other problems where switching to run_targets, especially with building proto_library rules even though normally these build just fine. I'll investigate it for the next release, but let's merge the current one as it is. Thank you

@fmeum fmeum merged commit 3f61474 into bazelbuild:main Jun 11, 2025
22 checks passed
@WojciechMazur WojciechMazur deleted the gazelle_cc-v0.1.0 branch June 11, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants