-
Notifications
You must be signed in to change notification settings - Fork 477
Publish [email protected] #4795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Wojciech Mazur <[email protected]>
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (gazelle_cc) have been updated in this PR. |
@WojciechMazur Windows fails |
…mmands)` are not executed on this platform
Head branch was pushed to by a user without write access
Require module maintainers' approval for newly pushed changes.
I've seen that step Our setup is mostly the same as in the https://github.com/bazel-contrib/bazel-gazelle/ but for some reason they seem to not have this problems. Probably, that's because presubmit is building existing targets instead of creating new ones, becouse without shell commands these were not erased. Because of these reasons I've decided to disable testing on Windows. Building existing target would be simply fruitless. |
@WojciechMazur You can use |
…n building generated proto_library targets, however previously these were building correctly
There were some other problems where switching to run_targets, especially with building proto_library rules even though normally these build just fine. I'll investigate it for the next release, but let's merge the current one as it is. Thank you |
Release: https://github.com/EngFlow/gazelle_cc/releases/tag/v0.1.0