-
Notifications
You must be signed in to change notification settings - Fork 499
jsinterop_generator@20250630 #5043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
jsinterop_generator@20250630 #5043
Conversation
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (jsinterop_generator) have been updated in this PR. |
@bazel-io skip_check incompatible_flags |
|
||
bazel_dep(name = "j2cl", repo_name = "com_google_j2cl") | ||
|
||
archive_override( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we switch to the BCR version? archive_override
won't work transitively
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I initially switched to stable bcr version, but my team suggests we want to test with the latest MASTER change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you do this, I'd caution against using bcr_test_module
with module_path: '.'
. You'd be doing running the BCR compatibility test with an override, which is certainly not what the BCR automation ought to be doing. It's fine for you to test compatibility with tip-of-tree master in your own CI (so leaving the overrides in is okay), but maybe not on BCR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly, you have to make sure what you check into BCR is actually usable by other people, with the current MODULE.bazel, j2cl will be missing when this module is used via a bazel_dep
, if you add a anonymous-module-test test, you'll probably catch this.
Release: https://github.com/google/jsinterop-generator/releases/tag/v20250630
Automated by Publish to BCR