Skip to content

jsinterop_generator@20250630 #5043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

publish-to-bcr-bot[bot]
Copy link
Contributor

@bazel-io
Copy link
Member

bazel-io commented Jul 1, 2025

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (jsinterop_generator) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@mollyibot
Copy link
Contributor

@bazel-io skip_check incompatible_flags

@bazel-io bazel-io added the skip-incompatible-flags-test Bypass the incompatible flags test in BCR presubmit label Jul 1, 2025
@Wyverald Wyverald added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Jul 1, 2025

bazel_dep(name = "j2cl", repo_name = "com_google_j2cl")

archive_override(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we switch to the BCR version? archive_override won't work transitively

Copy link
Contributor

@mollyibot mollyibot Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I initially switched to stable bcr version, but my team suggests we want to test with the latest MASTER change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you do this, I'd caution against using bcr_test_module with module_path: '.'. You'd be doing running the BCR compatibility test with an override, which is certainly not what the BCR automation ought to be doing. It's fine for you to test compatibility with tip-of-tree master in your own CI (so leaving the overrides in is okay), but maybe not on BCR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly, you have to make sure what you check into BCR is actually usable by other people, with the current MODULE.bazel, j2cl will be missing when this module is used via a bazel_dep, if you add a anonymous-module-test test, you'll probably catch this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-incompatible-flags-test Bypass the incompatible flags test in BCR presubmit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants