Skip to content

Publish [email protected] #5205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Publish [email protected] #5205

wants to merge 1 commit into from
+82 −0

Conversation

jjmaestro
Copy link

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (version_utils) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@jjmaestro
Copy link
Author

@bazel-io skip_check compatibility_level

@bazel-io bazel-io added the skip-compatibility-level-check Skip the compatibility_level check for MODULE.bazel label Jul 17, 2025
@jjmaestro jjmaestro marked this pull request as ready for review July 17, 2025 08:52
meteorcloudy
meteorcloudy reviewed Jul 17, 2025
View reviewed changes
modules/version_utils/0.1.0/MODULE.bazel
@@ -0,0 +1,8 @@
module(
name = "version_utils",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version_utils might be a bit too general, do you mind renaming it to bazel_version_utils?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal of the module is, ideally, to have all the version utils here, I'd love to move this to bazel-contrib so all repos can centralize whatever utils that deal with versioning schemes and version requirements (there's quite a few schemes like Rust's cargo, etc).

Given that, and that the module is clearly a Bazel module, what difference does it make to have bazel_ as a prefix? :-?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I was actually worried there might be other popular OSS project with this name, but it doesn't look like so. So I guess this is fine.

I'd love to move this to bazel-contrib so all repos can centralize whatever utils that deal with versioning schemes and version requirements

SG!

@meteorcloudy meteorcloudy added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Jul 17, 2025
@jjmaestro
Copy link
Author

I'll check the failures, all of them are in Windows, where I hadn't tested it I think! :S

@jjmaestro
Copy link
Author

Actually, I did test it across all platforms! And it worked on Windows! So I'm a bit surprised...

I think the error could be because I'm using a symlink, examples/suite.bzl --> ../tests/suite.bzl (a common helper file that I have for tests) and somehow, the CI Windows job in Buildkite doesn't like symlinks :-?

@meteorcloudy is this expected? :-?

@meteorcloudy
Copy link
Member

Maybe something doesn't work here https://github.com/bazelbuild/continuous-integration/blob/470f89c17ca8e7b52bb95184d24ab65d3d7f8cb3/buildkite/bazel-central-registry/bcr_presubmit.py#L256 ?

Can you help debug this? You can reproduce locally with https://github.com/bazelbuild/bazel-central-registry/tree/main/docs#reproduce-presubmit-builds-locally

@jjmaestro
Copy link
Author

Just a small update, I've been trying to get a Windows VM working, and then, get Bazel to run. I've now got it to run, but I'm getting a Python failure 😅 TL;DR I'll continue trying to get this up-and-running to repro and investigate what's going on, but... is there a better / simpler way to test this failure in e.g. a Windows docker image with everything setup or something along those lines? :-?

@meteorcloudy
Copy link
Member

Sorry, we are not using any Windows docker image, but I would expect the bazel build to be hermetic.

@jjmaestro
Copy link
Author

(...) but I would expect the bazel build to be hermetic

Yeah, I was expecting it too, but somehow, I'm getting this failure:

> bazel run //tools:setup_presubmit_repos -- --module [email protected]
Starting local Bazel server (8.3.1) and connecting to it...
ERROR: C:/users/javier/_bazel_javier/pqprrnwe/external/rules_python+/python/private/pypi/extension.bzl:124:17: Traceback (most recent call last):
        File "C:/users/javier/_bazel_javier/pqprrnwe/external/rules_python+/python/private/pypi/extension.bzl", line 625, column 25, in _pip_impl
                mods = parse_modules(module_ctx, enable_pipstar = rp_config.enable_pipstar)
        File "C:/users/javier/_bazel_javier/pqprrnwe/external/rules_python+/python/private/pypi/extension.bzl", line 501, column 36, in parse_modules
                out = _create_whl_repos(
        File "C:/users/javier/_bazel_javier/pqprrnwe/external/rules_python+/python/private/pypi/extension.bzl", line 124, column 17, in _create_whl_repos
                fail((
Error in fail: Unable to find interpreter for pip hub 'pip' for python_version=3.11: Make sure a corresponding `python.toolchain(python_version="3.11")` call exists.Expected to find python_3_11_host among registered versions:

ERROR: error evaluating module extension @@rules_python+//python/extensions:pip.bzl%pip
INFO: Elapsed time: 7.139s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target
FAILED:
    Fetching repository @@aspect_rules_js+; starting
    Fetching module extension @@rules_python+//python/extensions:pip.bzl%pip; starting
    Fetching C:/users/javier/_bazel_javier/pqprrnwe/external/aspect_rules_js+; Extracting rules_js-v2.4.0.tar.gz

I'll continue working on this later today, maybe it's something silly and easy to work around, or maybe I'm doing something wrong :) I'll keep you posted!

@jjmaestro
Copy link
Author

@meteorcloudy I've managed to install Python 3.11 and both python and pip are available but I'm getting the same failure (this is on a clean clone of the repo and checkout the PR branch):

> python --version
Python 3.11.9

> pip --version
pip 24.0 from C:\Program Files\Python311-arm64\Lib\site-packages\pip (python 3.11)

> bazel run //tools:setup_presubmit_repos -- --module [email protected]
Starting local Bazel server (8.3.1) and connecting to it...
ERROR: C:/users/javier/_bazel_javier/pqprrnwe/external/rules_python+/python/private/pypi/extension.bzl:124:17: Traceback (most recent call last):
        File "C:/users/javier/_bazel_javier/pqprrnwe/external/rules_python+/python/private/pypi/extension.bzl", line 625, column 25, in _pip_impl
                mods = parse_modules(module_ctx, enable_pipstar = rp_config.enable_pipstar)
        File "C:/users/javier/_bazel_javier/pqprrnwe/external/rules_python+/python/private/pypi/extension.bzl", line 501, column 36, in parse_modules
                out = _create_whl_repos(
        File "C:/users/javier/_bazel_javier/pqprrnwe/external/rules_python+/python/private/pypi/extension.bzl", line 124, column 17, in _create_whl_repos
                fail((
Error in fail: Unable to find interpreter for pip hub 'pip' for python_version=3.11: Make sure a corresponding `python.toolchain(python_version="3.11")` call exists.Expected to find python_3_11_host among registered versions:

ERROR: error evaluating module extension @@rules_python+//python/extensions:pip.bzl%pip
INFO: Elapsed time: 16.471s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target
FAILED:
    Fetching repository @@aspect_rules_js+; starting
    Fetching module extension @@rules_python+//python/extensions:pip.bzl%pip; starting
    Fetching C:/users/javier/_bazel_javier/pqprrnwe/external/aspect_rules_js+; Extracting rules_js-v2.4.0.tar.gz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-compatibility-level-check Skip the compatibility_level check for MODULE.bazel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjmaestro @bazel-io @meteorcloudy