Skip to content

Publish [email protected] #5338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

aspect-marvin
Copy link
Contributor

@bazel-io
Copy link
Member

Hello @alexeagle, @thesayyn, modules you maintain (tar.bzl) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@fmeum fmeum added the skip-source-repo-check Skip the source repository check for the PR label Jul 25, 2025
@fmeum
Copy link
Contributor

fmeum commented Jul 25, 2025

@alexeagle I skipped the source repo check, but there are other issues.

@alexeagle alexeagle force-pushed the tar.bzl-v0.5.0 branch 2 times, most recently from 4fb86c8 to e545f3e Compare July 25, 2025 22:17
@alexeagle
Copy link
Contributor

The attestation must include the source url that's being attested, so changing that breaks the attestation.


slsa-verifier verify-github-attestation \
--
  | --attestation-path /tmp/tmpwt_76hy5/source.json.intoto.jsonl \
  | --source-uri github.com/bazel-contrib/tar.bzl \
  | --builder-id https://github.com/bazel-contrib/publish-to-bcr/.github/workflows/publish.yaml \
  | modules/tar.bzl/0.5.0/source.json
  | BcrValidationResult.FAILED: [email protected]: SLSA verifier failed for source.json.intoto.jsonl:
  | Verifying artifact modules/tar.bzl/0.5.0/source.json: FAILED: expected hash '891084a72072cb32f26486919299ffcfce2ad5e4042658ac72e5758fe6d4b459' not found: artifact hash does not match provenance subject
  |  
  | FAILED: SLSA verification failed: expected hash '891084a72072cb32f26486919299ffcfce2ad5e4042658ac72e5758fe6d4b459' not found: artifact hash does not match provenance subject


I think that means we need to make other changes in the https://github.com/bazel-contrib/publish-to-bcr app to account for this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-source-repo-check Skip the source repository check for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants