-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Optimize retained size of Merkle trees #28260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
fmeum
wants to merge
18
commits into
bazelbuild:master
Choose a base branch
from
fmeum:optimize-merkle-tree-memory
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3f800fb to
f114ea8
Compare
By using JOL, the precise memory footprint of a `MerkleTree.Uploadable` can be measured in a unit test. This will serve as the basis for future memory improvements, with the aim of reducing peak heap usage while a `MerkleTree.Uploadable` is retained during the upload to the remote cache. This change also includes small tweaks to the `MerkleTree` interface that make future changes to its internals more transparent. It also makes some unit tests more realistic, which again prepares for future improvements.
fad85fc to
002be10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.