[8.6.0] Allow nonlocal tests with nobuild_runfile_manifests #28288
+27
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses bazelbuild#23980 When testing a large number of targets against a build farm, runfile manifests can start to pile up pretty quickly on the client, and take up a large amount of disk space. The runfile manifests are also unnecessary when performing tests with the sandboxed or remote spawn strategies, only (to my understanding) local or standalone. This change modifies the test wrappers to error early if the runfile directory can't be found, and instructs the user to build with runfile manifests, or change their execution strategy. We still need to be able to actually get the runfile directory when the input manifest isn't present. To address this, we also change the behavior of getRunfilesDirectory to just return the runfilesTreeArtifact's path. Closes bazelbuild#27412. PiperOrigin-RevId: 845855359 Change-Id: I761a79b1354879bce3622da4bacb3d5f04515a4f
Makes bazelbuild@374f82f compatible with 8.6.0
github-actions
bot
added
team-Configurability
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request allows running non-local tests with the --nobuild_runfile_manifests flag, which is a backport for version 8.6.0. The changes correctly modify how the runfiles directory path is determined to not rely on the manifest. Additionally, checks are added to the test setup scripts for both Unix and Windows to provide a clear error message when local execution strategies are used without a runfiles tree. The accompanying test updates accurately reflect these new behaviors. The implementation is clean, consistent, and looks correct.
Contributor
Author
|
thank you gemini that's very kind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
8.6.0 compatibility for 374f82f
This allows us to run nonlocal tests while supplying the --nobuild_runfile_manifests flag