Skip to content

Conversation

@fmeum
Copy link
Collaborator

@fmeum fmeum commented Jan 15, 2026

Important outputs and runfiles from external repos that are remote repo contents cache hits got stuck at various levels of the materialization pipeline for being source artifacts. This is fixed by consolidating the skip logic in a RemoteOutputChecker static helper.

@fmeum fmeum requested review from a team, Wyverald and meteorcloudy as code owners January 15, 2026 17:46
@fmeum fmeum requested review from tjgq and removed request for meteorcloudy January 15, 2026 17:47
@github-actions github-actions bot added team-Performance Issues for Performance teams team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. team-Remote-Exec Issues and PRs for the Execution (Remote) team awaiting-review PR is awaiting review from an assigned reviewer labels Jan 15, 2026
@fmeum
Copy link
Collaborator Author

fmeum commented Jan 15, 2026

@bazel-io fork 9.0.0

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request effectively addresses the issue of runfiles from remote external repositories not being materialized correctly by consolidating the skip logic into a new RemoteOutputChecker.mayBeRemote static helper. This change improves code maintainability by centralizing the logic for determining if an ActionInput could be remote. Additionally, the ActionExecutionMetadata parameter in ActionInputPrefetcher.prefetchFiles has been made nullable, which correctly handles scenarios where a generating action might not be available. The new testRun test case provides good coverage for the bazel run command's interaction with the remote repository contents cache, ensuring the fix works as expected.

@fmeum fmeum changed the title Materialize runfiles from remote external repos Materialize top-level targets from remote external repos Jan 15, 2026
@fmeum fmeum changed the title Materialize top-level targets from remote external repos Materialize important outputs from remote external repos Jan 15, 2026
Runfiles from external repos that are remote repo contents cache hits got stuck at various levels of the materialization pipeline for being source artifacts. This is fixed by consolidating the skip logic in a `RemoteOutputChecker` static helper.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-review PR is awaiting review from an assigned reviewer team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. team-Performance Issues for Performance teams team-Remote-Exec Issues and PRs for the Execution (Remote) team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant