Add and fix test target for stack_traces_integration_tests.sh
#28329
+48
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test case that verifies stack trace printing for SIGTERM during suite setup failed and is fixed by moving the installation of signal handlers to main.
fmeum
force-pushed
the
fix-stack-trace-integration-test
branch
from
9f9c965 to
26f8efb
Compare
fmeum
changed the title
stack_traces_integration_tests.shstack_traces_integration_tests.sh
github-actions
bot
added
team-Rules-Java
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly moves the SIGTERM signal handler installation to the beginning of the main method. This ensures that stack traces are printed even if the test process is terminated during test suite creation. The changes also include removing the now-redundant JUnit4TestStackTraceListener and updating the integration tests to verify the new behavior. My review includes suggestions to improve the reliability of the integration tests by replacing fixed sleep calls with a polling mechanism, which will help prevent test flakiness.
...tools/junitrunner/javatests/com/google/testing/junit/runner/stack_trace_integration_tests.sh
Show resolved
Hide resolved
...tools/junitrunner/javatests/com/google/testing/junit/runner/stack_trace_integration_tests.sh
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test case that verifies stack trace printing for SIGTERM during suite setup failed and is fixed by moving the installation of signal handlers to main.
A follow-up change will extend the stack trace logic as well as the test to record stack traces of virtual threads.
Work towards #28302