Fix apple_xcframework framework plist generated for invalid platform#2526
Open
zavsby wants to merge 2 commits intobazelbuild:mainfrom
Open
Fix apple_xcframework framework plist generated for invalid platform#2526zavsby wants to merge 2 commits intobazelbuild:mainfrom
zavsby wants to merge 2 commits intobazelbuild:mainfrom
Conversation
zavsby
requested review from
BalestraPatrick,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
zavsby
force-pushed
the
fix_xcframeworks_plists
branch
2 times, most recently
from
e263903 to
5a59387
Compare
zavsby
force-pushed
the
fix_xcframeworks_plists
branch
from
5a59387 to
a9aa138
Compare
luispadron
reviewed
Sep 13, 2024
Contributor
luispadron
left a comment
luispadron
left a comment
There was a problem hiding this comment.
Is there a test we could add for this behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing issue #2524: using apple_xcframework to generate a xcframework for ios (arm64 + arm64 simulator), Info.plist for frameworks is always generated same for simulator and device with same values in CFBundleSupportedPlatforms, DTPlatformName and DTSDKName.