Skip to content

Support tree artifact outputs in XCFramework rules#2785

Merged
luispadron merged 2 commits intomasterfrom
luis/xcframework-tree-artifacts-support
Nov 11, 2025
Merged

Support tree artifact outputs in XCFramework rules#2785
luispadron merged 2 commits intomasterfrom
luis/xcframework-tree-artifacts-support

Conversation

@luispadron
Copy link
Contributor

@luispadron luispadron commented Sep 12, 2025

Manual cherry-pick of: 3276c83

One thing i noticed was upstream is generating different static xcframeworks than we are, i didnt want to change that in this PR and not entirely sure which is correct.

Test from upstream:

expected_directories = {
    "ios_static_xcframework.xcframework": [
        "Info.plist",
        "ios-arm64/ios_static_xcframework.a",
        "ios-arm64/Headers/ios_static_xcframework/ios_static_xcframework.h",
        "ios-arm64/Headers/ios_static_xcframework/module.modulemap",
        "ios-arm64/Headers/ios_static_xcframework/shared.h",
        "ios-arm64_x86_64-simulator/ios_static_xcframework.a",
        "ios-arm64_x86_64-simulator/Headers/ios_static_xcframework/ios_static_xcframework.h",
        "ios-arm64_x86_64-simulator/Headers/ios_static_xcframework/module.modulemap",
        "ios-arm64_x86_64-simulator/Headers/ios_static_xcframework/shared.h",
    ],
},

Compared to what is created in master today:

expected_directories = {
    "ios_static_xcframework.xcframework": [
        "Info.plist",
        "ios-arm64/ios_static_xcframework.framework/ios_static_xcframework",
        "ios-arm64/ios_static_xcframework.framework/Headers/ios_static_xcframework.h",
        "ios-arm64/ios_static_xcframework.framework/Headers/shared.h",
        "ios-arm64/ios_static_xcframework.framework/Modules/module.modulemap",
        "ios-arm64_x86_64-simulator/ios_static_xcframework.framework/ios_static_xcframework",
        "ios-arm64_x86_64-simulator/ios_static_xcframework.framework/Headers/ios_static_xcframework.h",
        "ios-arm64_x86_64-simulator/ios_static_xcframework.framework/Headers/shared.h",
        "ios-arm64_x86_64-simulator/ios_static_xcframework.framework/Modules/module.modulemap",
    ],
},

luispadron referenced this pull request Sep 12, 2025
@luispadron luispadron force-pushed the luis/xcframework-tree-artifacts-support branch from 16daf1b to 3ded7b7 Compare September 12, 2025 04:51
@luispadron luispadron marked this pull request as ready for review September 12, 2025 18:22
@luispadron luispadron force-pushed the luis/xcframework-tree-artifacts-support branch from 3ded7b7 to 8283163 Compare September 29, 2025 15:18
@luispadron luispadron force-pushed the luis/xcframework-tree-artifacts-support branch from 8283163 to fcf8323 Compare November 11, 2025 15:52
@luispadron luispadron merged commit 680c227 into master Nov 11, 2025
11 checks passed
@luispadron luispadron deleted the luis/xcframework-tree-artifacts-support branch November 11, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants