Fix analysis tests for experimental_prune_transitive_deps #1418
+195
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agluszak
requested review from
Bencodes,
ahumesky,
cgruber,
nkoroste and
restingbull
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Revive PR bazelbuild#1343 by rbeazleyspot which adds analysis tests for the experimental_prune_transitive_deps feature. The original tests failed because config_settings creates a configuration transition, causing output paths to include a hash suffix (e.g., k8-fastbuild-ST-xxx). Fixed by comparing file basenames instead of full paths using matching.file_basename_equals() predicates.
…uild#1405) * Migrate from KSP1 (compiler plugin) to KSP2 (standalone tool) KSP2 is a standalone program that runs separately from the Kotlin compiler, unlike KSP1 which was a compiler plugin. This migration required: - Add KSP2 tool definition in kotlin/compiler/ksp.bzl and BUILD.bazel - Implement _run_ksp_builder_actions in compile.bzl to invoke KSP2 as a separate action that produces tree artifacts for generated sources - Add tree_artifact_packager worker to package KSP2 output directories into srcjars for downstream compilation - Fix source-roots handling: KSP2 expects directory paths, not file paths - Update examples/ksp to use bzlmod (MODULE.bazel) instead of WORKSPACE - Expand KSP test coverage with Dagger-based coffee example demonstrating mixed Kotlin/Java code generation scenarios Key changes: - KSP now runs as a pre-compilation step producing generated sources - Generated sources are packaged into srcjars and compiled with main sources - Removed KSP1-specific code from KotlinToolchain and InternalCompilerPlugins * WIP * WIP * Fix * Fix * Move staging to the builder * Add tests, remove unused code * Fix test * Update KSP to 2.3.3 * Remove the note about KSP multiplex workers support * Address code review issues * Revert unnecessary change * compile against the ksp concrete classes * Bump bazel version on CI * Bump RBE ubuntu version to support bazel 7.7.1 * Bump bazel version on CI to 8.4.2 * Fix stardoc generation --------- Co-authored-by: Corbin McNeely-Smith <58151731+restingbull@users.noreply.github.com>
* Document x_lambdas and x_sam_conversions defaults Explain that rules_kotlin defaults to "class" for x_lambdas and x_sam_conversions, differing from Kotlin 2.x/Gradle's "indy" default. Add README section with configuration examples for Gradle-compatible bytecode generation. Update API docs in opts.kotlinc.bzl to clarify the default behavior and compatibility implications. Closes bazelbuild#1417 * Simplify README lambda bytecode documentation Reduce the documentation to a concise note within the existing "Kotlin and Java compiler flags" section, with a single code example showing how to configure for invokedynamic behavior.
agluszak
force-pushed
the
pr-1343-analysis-test
branch
from
91d176d to
3dd8fa5
Compare
Bencodes
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revive PR #1343 by rbeazleyspot which adds analysis tests for the
experimental_prune_transitive_deps feature.
The original tests failed because config_settings creates a configuration
transition, causing output paths to include a hash suffix (e.g.,
k8-fastbuild-ST-xxx). Fixed by comparing file basenames instead of full
paths using matching.file_basename_equals() predicates.