Fix JaCoCo coverage issue with rules_java 9.3.0+ #1448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agluszak
requested review from
Bencodes,
ahumesky,
cgruber,
nkoroste and
restingbull
as code owners
Reorder runtime_deps to put @bazel_tools//tools/jdk:JacocoCoverage before the worker. This ensures the newer JaCoCo classes are loaded first, fixing the NoClassDefFoundError caused by version mismatch between rules_kotlin (JaCoCo 0.8.11) and rules_java 9.3.0+ (JaCoCo 0.8.14). Also adds a coverage example to verify the fix.
Bencodes
reviewed
Jan 20, 2026
examples/coverage/test_coverage.sh
Outdated
| @@ -0,0 +1,36 @@ | |||
| #!/bin/bash | |||
Collaborator
There was a problem hiding this comment.
Nothing actually invokes this script to verify that coverage actually works, is that intentional?
restingbull
reviewed
Jan 22, 2026
| ).onFailThrow() | ||
| } | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Why not just add coverage as a command to the integration test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorder runtime_deps to put @bazel_tools//tools/jdk:JacocoCoverage before the worker. This ensures the newer JaCoCo classes are loaded first, fixing the NoClassDefFoundError caused by version mismatch between rules_kotlin (JaCoCo 0.8.11) and rules_java 9.3.0+ (JaCoCo 0.8.14).
Also adds a coverage example to verify the fix.
Fixes #1447