Skip to content

Conversation

@gsingh93
Copy link
Contributor

@gsingh93 gsingh93 commented Sep 2, 2022

While #371 was meant to be a non-controversial change, making the tab-line style consistent with tab-bar, this PR updates the styles of both to look "better" (in my opinion). The changes include:

  • Make the tab-bar font size slightly bigger to improve readability
  • Add padding around the tab text
  • Change the box style from released/pressed button to nil, for a more flat, modern look.
  • Removed the separators between tabs (note that for some reason, the only way to do this and preserve the padding with tab-bar is to use a zero-width space)

Before:
image
After:

image

Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've added a before/after screenshot illustrating visually your changes.
  • You've updated the changelog (if adding/changing user-visible functionality - e.g. theme new faces/packages, changing existing faces, etc)
  • You've updated the readme (if adding/changing configuration options)

Thanks!

@gsingh93
Copy link
Contributor Author

gsingh93 commented Sep 2, 2022

I'm not sure if I'm setting the tab-bar-separator and tab-line-separator variables in the right spot. When I load emacs for the first time, tab-bar-separator is set but tab-line-separator is not. But if I run M-X load-theme RET zenburn, then both variables are set. It's probably related to the loading order, where tab-line-mode overwrites this variable when it's loaded, which is after the theme. I'm not sure how to do this in an order-independent way.

@gsingh93
Copy link
Contributor Author

gsingh93 commented Sep 3, 2022

There's a weird issue with tab-line groups. Here's how it looks at first:
image

Hovering over the group, you can see some of the hover bleeding over into the buffer name:
image

Moving the mouse off of it leaves that discoloration there:
image

And then after hovering over the buffer name and moving the cursor away, things go back to normal, like the first image.

@bbatsov
Copy link
Owner

bbatsov commented Sep 27, 2022

No idea about this issue - never used tab-bar, but I assume it's using some overlays to simulate the tabs and I've seen plenty of glitches with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants