This repository was archived by the owner on Oct 18, 2024. It is now read-only.
Update dependency eslint-plugin-react to ^7.33.2#60
Open
bbc-search-and-navigation wants to merge 1 commit intomasterfrom
Open
Update dependency eslint-plugin-react to ^7.33.2#60bbc-search-and-navigation wants to merge 1 commit intomasterfrom
bbc-search-and-navigation wants to merge 1 commit intomasterfrom
Conversation
c046244 to
9f27c33
Compare
9f27c33 to
0182a58
Compare
0182a58 to
9d6e5db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^7.30.0->^7.33.2Release Notes
jsx-eslint/eslint-plugin-react (eslint-plugin-react)
v7.33.2Compare Source
Fixed
no-deprecated]: prevent false positive on commonjs import (#3614 @akulsr0)no-unsafe]: report on the method instead of the entire component (@ljharb)no-deprecated]: report on the destructured property instead of the entire variable declarator (@ljharb)no-deprecated]: report on the imported specifier instead of the entire import statement (@ljharb)no-invalid-html-attribute]: report more granularly (@ljharb)v7.33.1Compare Source
Fixed
require-default-props]: fix config schema (#3605 @controversial)jsx-curly-brace-presence]: Revert [#3538][] due to issues with intended string type casting usage (#3611 @taozhou-glean)sort-prop-types]: ensure sort-prop-types respects noSortAlphabetically (#3610 @caesar1030)v7.33.0Compare Source
Added
display-name]: addcheckContextObjectsoption (#3529 @JulesBlm)jsx-first-prop-new-line]: addmultipropoption (#3533 @haydncomley)no-deprecated]: add React 18 deprecations (#3548 @sergei-startsev)forbid-component-props]: adddisallowedForoption (#3417 @jacketwpbb)Fixed
no-array-index-key]: consider flatMap (#3530 @k-yle)jsx-curly-brace-presence]: handle single and only expression template literals (#3538 @taozhou-glean)no-unknown-property]: allowonLoadonsource(@ljharb)jsx-first-prop-new-line]: ensure autofix preserves generics in component name (#3546 @ljharb)no-unknown-property]: allowfillprop on<symbol>(#3555 @stefanprobst)display-name], [prop-types]: when checking for a capitalized name, ignore underscores entirely (#3560 @ljharb)no-unused-state]: avoid crashing on a class field function with destructured state (#3568 @ljharb)no-unused-prop-types]: allow using spread with object expression in jsx (#3570 @akulsr0)destructuring-assignment]: Handle destructuring of useContext in SFC" (#3583 [#2797][] @102)prefer-read-only-props]: add TS support (#3593 @HenryBrown0)Changed
jsx-newline], [no-unsafe], [static-property-placement]: Fix code syntax highlighting (#3563 @nbsp1221)jsx-no-bind]: reword performance rationale (#3581 @gpoole)jsx-first-prop-new-line]: add missingmultipropvalue (#3598 @dzek69)v7.32.2Compare Source
Fixed
parserOptionsin legacy configs ([#3523][] @ljharb)jsx-no-constructed-context-values], [jsx-no-useless-fragment]: add a rule schema (@ljharb)( [
no-unknown-property]: addfillfor<marker>(#3525 @alexey-koran)v7.32.1Compare Source
Fixed
destructuring-assignment]: do not force destructuring of optionally chained properties (#3520 @ljharb)v7.32.0Compare Source
Added
hook-use-state]: addallowDestructuredStateoption (#3449 @ljharb)sort-default-props] and deprecate [jsx-sort-default-props] (#1861 @alexzherdev)no-object-type-as-default-prop] rule (#2848 @cyan33 @fengkx)Fixed
sort-prop-types]: restore autofixing (#3452, #3471 @ROSSROSALES)no-unknown-property]: do not checkfbselements (#3494 @brianogilvie)jsx-newline]: No newline between comments and jsx elements (#3493 @justmejulian)jsx-no-leaked-render]: Don't report errors on empty strings if React >= v18 (#3488 @himanshu007-creator)no-invalid-html-attribute]: convert autofix to suggestion (#3474 @himanshu007-creator @ljharb)jsx-no-leaked-render]: fix removing parentheses for conditionals (#3502 @akulsr0)jsx-no-leaked-render]: invalid fixes in coerce mode (#3511 @akulsr0)destructuring-assignment]: Handle destructuring of useContext in SFC (#2797 @Zinyon @ljharb)Changed
jsx-no-leaked-render]: Remove mentions of empty strings for React 18 (#3468 @karlhorky)eslint-doc-generatorto v1.0.0 (#3499 @bmish)prefer-exact-props]: fix example flow syntax (#3510 @smackfu)anyOfinstead ofoneOf(@ljharb @remcohaszing)v7.31.11Compare Source
Fixed
jsx-no-target-blank]: allow ternaries with literals (#3464 @akulsr0)no-unknown-property]: addinertattribute (#3484 @ljharb)jsx-key]: detect keys in logical expression and conditional expression (#3490 @metreniuk)Changed
forbid-component-props: inclusive language w/ allowlist (#3473 @AndersDJohnson)eslint-doc-generator(#3469 @bmish)v7.31.10Compare Source
Fixed
no-unknown-property]: allowallowFullScreenoniframe(#3455 @almeidx)v7.31.9Compare Source
Fixed
no-unknown-property]: adddialogattributes (#3436 @ljharb)no-arrow-function-lifecycle]: when converting from an arrow, remove the semi and wrapping parens (#3337 @ljharb)jsx-key]: Ignore elements insideReact.Children.toArray()(#1591 @silvenon)jsx-no-constructed-context-values]: fix false positive for usage in non-components (#3448 @golopot)static-property-placement]: warn on nonstatic expected-statics (#2581 @ljharb)no-unknown-property]: properly tag-restrict case-insensitive attributes (@ljharb)no-unknown-property]: allowwebkitDirectoryoninput, case-insensitive (#3454 @ljharb)Changed
no-unknown-property]: fix typo in link (#3445 @denkristoffer)no-unstable-nested-components]: Warn about memoized, nested components (#3444 @eps1lon)v7.31.8Compare Source
Fixed
no-unknown-property]: addviewBoxonmarker(#3416 @ljharb)no-unknown-property]: addnoModuleonscript(#3414 @ljharb)no-unknown-property]: allowonLoadon<object>(#3415 @OleksiiKachan)no-multi-comp]: do not detect a function property returning only null as a component (#3412 @ljharb)no-unknown-property]: allowabbron<th>and<td>(#3419 @OleksiiKachan)no-unknown-property]: addviewBoxforpattern,symbol,view(#3424 @MNBuyskih)no-unknown-property]: addalignon all the tags that support it (#3425 @ljharb)Changed
v7.31.7Compare Source
Fixed
no-unknown-property]: avoid warning onfbtnodes entirely (#3391 @ljharb)no-unknown-property]: adddownloadproperty support foraandarea(#3394 @HJain13)no-unknown-property]: allowwebkitAllowFullScreenandmozAllowFullScreen(#3396 @ljharb)no-unknown-property]:controlsList, notcontrolList(#3397 @ljharb)no-unknown-property]: add more capture event properties (#3402 @sjarva)no-unknown-property]: Add more one word properties found in DefinitelyTyped's react/index.d.ts (#3402 @sjarva)no-unknown-property]: Mark onLoad/onError as supported on iframes (#3398 @maiis, #3406 @akx)no-unknown-property]: allowimageSrcSetandimageSizesattributes on<link>(#3407 @terrymun)no-unknown-property]: addborder;focusableon<svg>(#3404 #3404 @ljharb)no-unknown-property]: React lowercasesdata-attrs (#3395 @ljharb)no-unknown-property]: addvalignon table components (#3389 @ljharb)v7.31.6Compare Source
Fixed
no-unknown-property]:onErrorandonLoadboth work onimgandscript(#3388 @ljharb)no-unknown-property]: data-* attributes can have numbers (#3390 @sjarva)no-unknown-property]: add more audio/video attributes (#3390 @sjarva)no-unknown-property]: move allowfullscreen to case ignored attributes (#3390 @sjarva)no-unknown-property]: fill works on line, mask, and use elements (#3390 @sjarva)no-unknown-property]: add onMouseMoveCapture as valid react-specific attribute (#3390 @sjarva)no-unknown-property]: make onLoad and onError be accepted on more elements (#3390 @sjarva)Changed
no-unknown-property]: add a mention about using ignores properties with libraries that add props (#3390 @sjarva)v7.31.5Compare Source
Fixed
no-unknown-property]: add propertiesonToggle,fill,as, and pointer events (#3385 @sjarva)no-unknown-property]: adddefaultCheckedproperty (#3385 @sjarva)no-unknown-property]: add touch and media event related properties (#3385 @sjarva)no-unknown-property]:childrenis always an acceptable prop; iframes havescrolling; video hasplaysInline(#3385 @ljharb)v7.31.4Compare Source
Fixed
no-unknown-property]: supportcheckedon inputs (#3383 @ljharb)v7.31.3Compare Source
Fixed
no-unknown-property]: add SVG and meta properties (#3381 @AhmadMayo)v7.31.2Compare Source
Fixed
jsx-key]: avoid a crash with optional chaining (#3371 @ljharb)jsx-sort-props]: avoid a crash with spread props (#3376 @ljharb)no-unknown-property]: properly recognize valid data- and aria- attributes (#3377 @sjarva)no-unknown-property]: properly recognize unknown HTML/DOM attributes (#3377 @sjarva)Changed
jsx-sort-props]: replace ref string with ref variable (#3375 @Luccasoli)no-unknown-property]: improve jsdoc; extract logic to separate functions (#3377 @sjarva)no-unknown-property]: update DOM properties to include also one word properties (#3377 @sjarva)v7.31.1Compare Source
Fixed
jsx-no-target-blank]: allow ternaries with literals (#3464 @akulsr0)no-unknown-property]: addinertattribute (#3484 @ljharb)jsx-key]: detect keys in logical expression and conditional expression (#3490 @metreniuk)Changed
forbid-component-props: inclusive language w/ allowlist (#3473 @AndersDJohnson)eslint-doc-generator(#3469 @bmish)v7.31.0Compare Source
Added
jsx-newline]: addallowMultilineoption when prevent option is true (#3311 @TildaDares)forbid-dom-props]: adddisallowedForoption (#3338 @TildaDares)Fixed
jsx-no-literals]: properly error on children with noAttributeStrings: true (#3317 @TildaDares)jsx-key]: catch key errors inside conditional statements (#3320 @TildaDares)display-name]: Accept forwardRef and Memo nesting in newer React versions (#3321 @TildaDares)jsx-key]: avoid a crash from optional chaining from #3320 (#3327 @ljharb)jsx-key]: avoid a crash on a non-array node.body from #3320 (#3328 @ljharb)display-name]: fix false positive for assignment of function returning null (#3331 @apbarrero)display-name]: fix identifying_as a capital letter (#3335 @apbarrero)require-default-props]: avoid a crash when function has no props param (#3350 @noahnu)display-name], component detection: fix HOF returning null as Components (#3347 @jxm-math)forbid-prop-types]: Ignore objects that are not of type React.PropTypes (#3326 @TildaDares)display-name], component detection: fix false positive for HOF returning only nulls and literals (#3305 @golopot)jsx-no-target-blank]: False negative when rel attribute is assigned using ConditionalExpression (#3332 @V2dha)jsx-no-leaked-render]: autofix nested "&&" logical expressions (#3353 @hduprat)jsx-sort-props]: sorted attributes now respect comments (#3358 @ROSSROSALES)Changed
jsx-indent-props]: improved readability of the checkNodesIndent function (#3315 @caroline223)jsx-indent], [jsx-one-expression-per-line]: add passing test cases (#3314 @ROSSROSALES)boolean-prop-naming,jsx-indent: avoid assigning to arguments (#3316 @caroline223)sort-comp]: add class component examples (#3339 @maurer2)jsx-no-useless-fragment]: add more examples of correct code (#3349 @karlhorky)jsx-boolean-value]: add jsdoc types for helper functions (#3344 @caroline223)jsx-closing-bracket-location], [jsx-no-bind]: fix eslint issues (#3351 @caroline223)function-component-definition]: add passing test cases (#3355 @TildaDares)jsx-no-target-blank]: Fix link to link-type-noreferrer (#3319 @Luccasoli)v7.30.2Compare Source
v7.30.1Compare Source
Fixed
display-name]: fix false positive for HOF returning only nulls (#3291 @golopot)jsx-no-leaked-render]: avoid unnecessary negation operators and ternary branches deletion (#3299 @Belco90)display-name]: fix false positive when using memo (#3304 @golopot)Changed
jsx-tag-spacing]: rename option from [#3264][] ([#3294[] @ljharb)jsx-key]: split the examples (#3293 @ioggstream)Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - "after 7am and before 3pm every weekday" (UTC).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
PR was created by CD-Renovate.