-
Notifications
You must be signed in to change notification settings - Fork 3
Release v1.1.0 #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.1.0 #43
Conversation
…-crashes-on-command OpenVariant Bug plugin creation crashes on command
…ut-has-empty-lines 44 OpenVariant Bug breaks when input has empty lines
…file-permission-denied 18 OpenVariant Dont fail if folderfile permission denied
I've added two commits that address the two comments I made some time ago. If nothing else needs to be done here I think we can release. What do you think? |
Cool, but skip is also present in the other commands cat and count. I think that we should add the default as well. |
Good catch! I totally missed them - I force pushed with the addition in the latest commit! Thanks |
Perfect!! :) |
I've fixed a small inconsistency in handling windows-based file and linux based ones. issue here #47 we could include that fix as well in this release and ship it this week. |
yes, thanks! |
…sed-properly fix: replace newline removal with rstrip for better line handling
Fixed |
Release v1.1.0, with:
--skip
flag) 18 OpenVariant Dont fail if folderfile permission denied #46Before approve PR and merge, we should:
release_notes
section on Documentation.Since this PR adds a minor feature, we will update OpenVariant to v1.1.0 rather than v1.0.2 (which just implies a simple bug fix).