Skip to content

Release v1.1.0 #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Apr 7, 2025
Merged

Release v1.1.0 #43

merged 20 commits into from
Apr 7, 2025

Conversation

dmartmillan
Copy link
Collaborator

@dmartmillan dmartmillan commented Mar 10, 2025

Release v1.1.0, with:

Before approve PR and merge, we should:

  • Add changes to release_notes section on Documentation.
  • Create a tag for v1.1.0.
  • Upload the new version on PyPI.

Since this PR adds a minor feature, we will update OpenVariant to v1.1.0 rather than v1.0.2 (which just implies a simple bug fix).

@dmartmillan dmartmillan self-assigned this Mar 10, 2025
@dmartmillan dmartmillan added the bug Something isn't working label Mar 10, 2025
@FedericaBrando
Copy link
Member

I've added two commits that address the two comments I made some time ago.

If nothing else needs to be done here I think we can release. What do you think?

@dmartmillan
Copy link
Collaborator Author

I've added two commits that address the two comments I made some time ago.

If nothing else needs to be done here I think we can release. What do you think?

Cool, but skip is also present in the other commands cat and count. I think that we should add the default as well.

@FedericaBrando
Copy link
Member

Good catch! I totally missed them - I force pushed with the addition in the latest commit! Thanks

@dmartmillan
Copy link
Collaborator Author

Good catch! I totally missed them - I force pushed with the addition in the latest commit! Thanks

Perfect!! :)

@FedericaBrando
Copy link
Member

I've fixed a small inconsistency in handling windows-based file and linux based ones. issue here #47

we could include that fix as well in this release and ship it this week.

@dmartmillan
Copy link
Collaborator Author

I've fixed a small inconsistency in handling windows-based file and linux based ones. issue here #47

we could include that fix as well in this release and ship it this week.

yes, thanks!

@dmartmillan dmartmillan linked an issue Apr 7, 2025 that may be closed by this pull request
dmartmillan and others added 2 commits April 7, 2025 16:23
…sed-properly

fix: replace newline removal with rstrip for better line handling
@dmartmillan
Copy link
Collaborator Author

Fixed release_notes on the docs, with the last fix.

@FedericaBrando FedericaBrando self-requested a review April 7, 2025 14:47
@FedericaBrando FedericaBrando merged commit 271ee6e into master Apr 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants