Allow for flat indexing #148
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is similar to the default view that tumblr gives. Also has paging support
senorsnrub
force-pushed
the
add_flat_indexing
branch
from
89a6ea3 to
6e08cb4
Compare
Owner
|
Thanks! One remark, though: It looks like you copied a lot of code from class Index. Can you make class FlatIndex a subclass of Index to reduce the duplications? |
Author
|
Yeah I can clean it up a bit. It actually doesn't share very much actual logic - I think just the initializer, where some of the variables aren't being used. I think not having them subclassed makes more sense(or creating an abstract superclass that exposes the interface - basically just add_post and save_index) . Thoughts? |
|
+1 to this, would love to see it merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to the default view that tumblr gives. Also has paging & tags support