Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for flat indexing #148

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

senorsnrub
Copy link

This is similar to the default view that tumblr gives. Also has paging & tags support

This is similar to the default view that tumblr gives. Also has paging support
@bbolli
Copy link
Owner

bbolli commented Dec 6, 2018

Thanks! One remark, though: It looks like you copied a lot of code from class Index. Can you make class FlatIndex a subclass of Index to reduce the duplications?

@senorsnrub
Copy link
Author

senorsnrub commented Dec 7, 2018

Yeah I can clean it up a bit. It actually doesn't share very much actual logic - I think just the initializer, where some of the variables aren't being used. I think not having them subclassed makes more sense(or creating an abstract superclass that exposes the interface - basically just add_post and save_index) . Thoughts?

@tari3x
Copy link

tari3x commented Nov 29, 2020

+1 to this, would love to see it merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants